Bug 135061 - [api] make public constants for private edit menu groups
Summary: [api] make public constants for private edit menu groups
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P2 trivial (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Tom Hofmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2006-04-05 11:52 EDT by Tom Hofmann CLA
Modified: 2006-04-06 08:18 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hofmann CLA 2006-04-05 11:52:26 EDT 
N20060407

To get stable ordering of actions in the edit menu (see also bug 134965), we introduced edit menu groups for 
- assist
- information

These should be made part of the API constants as ITextEditorActionConstants.GROUP_XXX.

Affected CUs:
- BasicTextEditorActionContributor.java
- BasicJavaEditorActionContributor.java
- PropertiesFileEditorActionContributor.java
- BasicCompilationUnitEditorActionContributor.java
Comment 1 Tom Hofmann CLA 2006-04-05 12:25:12 EDT 
Note that this does not propose a 3.2 API change.
Comment 2 Dani Megert CLA 2006-04-05 12:27:32 EDT 
Mike can you approve the addition of the two constants? This will allow clients to contribute to those new menu groups.
Comment 3 Dani Megert CLA 2006-04-05 12:28:45 EDT 
Just to clarify: Tom posted comment 1 before we decided to publish them for 3.2.
Comment 4 Mike Wilson CLA 2006-04-05 13:15:48 EDT 
As long as this doesn't impact existing clients, I'm ok with it. +1. ok to proceed.
Comment 5 Dani Megert CLA 2006-04-06 03:02:26 EDT 
Tom, please proceed.
Comment 6 Tom Hofmann CLA 2006-04-06 03:43:23 EDT 
fixed > 20060406