Bug 134730 - [ErrorHandling] [About] About dialog needs to handle invalid images
Summary: [ErrorHandling] [About] About dialog needs to handle invalid images
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2006-04-04 08:30 EDT by Tod Creasey CLA
Modified: 2021-10-20 10:02 EDT (History)
6 users (show)

See Also:


Attachments
handlind inv.images (2.87 KB, patch)
2007-01-09 07:51 EST, bugzzy CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2006-04-04 08:30:54 EDT
M6

See Bug 107925. if an invalid image is used we are not handling the exception with the red x like we should.
Comment 1 Sriharsha Prabhakar CLA 2006-10-11 08:17:18 EDT
Kindly update us on the status of this defect.
Comment 2 Tod Creasey CLA 2006-10-19 07:25:22 EDT
If we intend to fix a bug for a particular release we mark it in target milestone. 
Comment 3 Tod Creasey CLA 2006-10-19 07:26:00 EDT
Please feel free to submit a patch
Comment 4 bugzzy CLA 2007-01-07 08:55:14 EST
would it be ok to catch exceptions from ImageDescriptor.createImage()?
Another solution is to delegate createImage to some registry or utility (I don't know which exactly) which will handle any exceptions.
As there seem to be an unknown number of exceptions, that createImage might throw, not only java.lang.NegativeArraySizeException which started this bug.
Comment 5 Tod Creasey CLA 2007-01-08 10:27:25 EST
Another error case to address
Comment 6 bugzzy CLA 2007-01-09 07:49:45 EST
below i submit a patch with catching exceptions and processing them by StatusManager, however it still might not be very strightforward, because only errors not handled by SWT will be processed. i.e. if some errors will cause that SWT return a default image (well known red square), nothing is logged. But if SWT will fail with exception, then there is no image at all (like the product had not configured any) and status is logged.
similarly with features buttons, which also might have invalid images.
Comment 7 bugzzy CLA 2007-01-09 07:51:53 EST
Created attachment 56624 [details]
handlind inv.images
Comment 8 Szymon Brandys CLA 2008-06-09 10:54:51 EDT
I have run out of time. To address in 3.5.
Comment 9 Boris Bokowski CLA 2009-05-06 16:48:44 EDT
Removing 3.5 target milestone. We are in the end-game now. Please have a look and decide if this should be targeted at 3.6.
Comment 10 Eclipse Webmaster CLA 2019-09-06 16:07:06 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 11 Eclipse Genie CLA 2021-10-20 10:02:53 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.