Community
Participate
Working Groups
IDEWorkbenchWindowAdvisor#openWelcomeEditors calls Bundle#start explicitly. This causes the bundle to be started eagerly the next time Eclipse comes up. We should change it so that this does not happen. Tom, what is the recommended way of dealing with this? The reason for starting the bundle at that time (before showing the welcome editor) is to give it a chance to perform first-time initialization tasks. Should we use deprecated methods from core.compatibility? Just for context: Welcome editors are deprecated and have been replaced by the "intro" support for some time now. (I believe intro was introduced in 3.0).
CC'ing Kim as the owner of the [Intro] component area.
(See bug 134412 for the context in which we found this issue.)
I think there should be a story for dropping compatibility support. IMHO the old welcome pages are a good candidate for Eclipse 4.0 ;)
Actually, If I understand the code correctly, I would recommend you continue to call bundle.start() in this case, but you should immediately call bundle.stop after the activation (in a finally block on the surrounding try to bundle.start). I only recommend you do this if the following is true: 1) This is only done when a legacy plug-in defines a deprecated wecome editor. 2) This is only done when a new feature is installed and you ensure that you do not call bundle.start and bundle.stop when you restart from a cached state. I assume this is the case because of the call to wbAdvisor.getNewlyAddedBundleGroups(). I assume this returns an empty set if you restart from a cached state.
seems pretty strange. What sort of initialization is likely to be done? seems like it would be good to get out of this situation if at all possible
Nick, would you be able to respond to Jeff's comment #5 ?
IIRC, WSADIE needed to do some post-install configuration. I believe it only starts the feature plugins for newly-installed features. I believe the old code just used IPluginDescriptor.getPlugin(), which didn't have the "if you start me up, start me up I'll never stop" behaviour. We'd have to check with KevinM or Greg to see if it's still an issue. I'll email them.
Nick, did you get a response yet?
No, I asked Greg but did not get a response. Since AFAIK nobody uses the legacy welcome editors anymore, I don't think this is a significant issue. I suggest following Tom's recommendations in comment 4. His assumptions are correct.
Created attachment 38439 [details] patch
Tom, could you have a look at the patch? Is this what you suggested in comment #4?
+1 patch looks good.
Released >20060412
Verified using I20060602-0010.
