Bug 132318 - [api][hovering][rulers] give access to the current annotation hover
Summary: [api][hovering][rulers] give access to the current annotation hover
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2006-03-17 07:05 EST by Tom Hofmann CLA
Modified: 2006-03-27 14:50 EST (History)
2 users (show)

See Also:

Attachments
org.eclipse.jface.text.diff (5.03 KB, patch)
2006-03-17 07:05 EST, Tom Hofmann CLA 		no flags Details | Diff
JavaEditor.java.diff (7.17 KB, patch)
2006-03-17 07:06 EST, Tom Hofmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hofmann CLA 2006-03-17 07:05:28 EST 
I20060315-1200

There is no way to get a hold of the currently showing annotation hover, similar to what ITextViewer::getCurrentTextHover provides.

I will add a patch that provides similar API on ISourceViewerExtension3.
Comment 1 Tom Hofmann CLA 2006-03-17 07:05:56 EST 
Created attachment 36476 [details]
org.eclipse.jface.text.diff

Patch against jface.text.
Comment 2 Tom Hofmann CLA 2006-03-17 07:06:51 EST 
Created attachment 36477 [details]
JavaEditor.java.diff

Patch against JavaEditor.java, to treat visible annotation hovers similar to the text hovers when F2 is pressed.
Comment 3 Tom Hofmann CLA 2006-03-17 07:07:46 EST 
See also bug 66661 and bug 98482 for similar requests (for quick diff and the overview ruler).
Comment 4 Erich Gamma CLA 2006-03-17 07:14:51 EST 
+1
Comment 5 Dani Megert CLA 2006-03-24 05:41:09 EST 
Please resolve for M6.
Comment 6 Dani Megert CLA 2006-03-27 09:34:35 EST 
I looked through the patches and released the API part in Platform Text with some modifications:
- rejected change to visibility of fVerticalRulerHoveringController: this should
  remain private and there's no need to make it package visible - at least not
  for this PR
- added missing @since 3.2 tags
- added missing Javadoc

The change in the Java editor is half-backed and can't be released as is: the interaction between text and annotation hover is often wrong and the position of the annotation presenter is off by one line. I filed bug 133355 to fix this in RC1.

Marking this bug as fixed since the API is in place.
Comment 7 John Arthorne CLA 2006-03-27 13:47:06 EST 
Note that the added method to ISourceViewerExtension3 is a breaking change for any client implementing this interface.  A warning should be sent to the mailing list to give adopters advance notice of the change.
Comment 8 Dani Megert CLA 2006-03-27 14:50:52 EST 
Thanks John, I will send a note to the list.