Bug 132136 - Problem on list/table group key
Summary: Problem on list/table group key
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: Future   Edit
Assignee: Zhiqiang Qian CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-16 07:06 EST by ysun CLA
Modified: 2007-10-24 06:24 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ysun CLA 2006-03-16 07:06:03 EST
Details:
Problem on list/table group key

Setp:
1.Insert a list/table and bending a dataset.
2.Insert a group and without edit something, press OK.
3.A group and a data in group are add in list/table.
4.Double click the data item and select one data column.
5.Preview.

Actual result:
The list/table can't be preview and pop up the error message.

Exception result:
The idea of DTE is that the group key is blank. User will modify the content with double click to open the data item to edit, but open the group editor dialog. Set the first data item's content to the group key, in other word, we can use the content of the data item which id is the smallest to be the group key.
Comment 1 Gary Xue CLA 2006-03-17 21:20:00 EST
Rather than picking a group key column for the user (which may not be what the user wants anyway) we should always require the user to select a group key when creating a new group. I suggest that
(1) If the "Group On" field is empty, the "Edit Group" dialog should report an error message to let the user know that the group definition is incomplete when the user tries to close the dialog. 
(2) An incompletely defined group (without a group key) should cause a syntax error to be displayed in the outline view. 
Comment 2 ysun CLA 2006-03-23 02:55:47 EST
How about user has not input the group key, the button of "OK" must be gray?
Comment 3 Wenfeng Li CLA 2006-05-21 22:56:26 EDT
Either add an error message or grey out OK button when group key is not defined.
Comment 4 Wang Qiangsheng CLA 2006-05-26 00:07:15 EDT
I think this require by document team, who create the template. They need create at table with Group, but withou data set binding.
I think it's reasonable that user want to create a blank table with group. They can dynamic binding them later by script.
Comment 5 Wenfeng Li CLA 2006-05-26 03:13:11 EDT
I think a template with group that has no group key probably is not that useful, since if the user knows how to open the group to set the group key, it would be just as easy for the user to create a group and then set the group key.  

Similary, a script that set the binding and group key can create the group as well in stead of relying on the report having a group already.

I think we can take Gary's suggestion to improve the UI.

Comment 6 Wang Qiangsheng CLA 2006-05-26 03:25:14 EDT
The Gary's suggestion is the init versoin of ours.
But We have those template,which contain's group withou data binding, now in our predefined template list. Do we plan to change them or keep it as is and just do the enhancement?
Comment 7 Wenfeng Li CLA 2006-05-26 03:46:20 EDT
I will take a look at the templates tomorrow.  Are they in the default list of templates in the new report wizard.
Comment 8 Wang Qiangsheng CLA 2006-05-29 23:28:37 EDT
Please see gourped list template.
That's the default template in the new report wizard
Comment 9 Wenfeng Li CLA 2006-06-05 01:35:42 EDT
Review the need of supporting template that has group without group key and the ease of use of creating a group.  Wait for more user feedback to decide which way to go.
Comment 10 Wenfeng Li CLA 2006-06-05 01:37:36 EDT
reopen for future consideration.