Description Mihoko Aoki 2006-03-16 00:47:17 EST

When the tabbed properties view displays dynamic tabs, tab selection sometimes flickers.

To get the latest tab selection in TabbedPropertySheetPage#setInput method, getLastTabSelection method is called.

Refering to the attached source codes, TabDescriptors are used to get the latest selection, but it seems that those TabDescriptors are STATIC.
So, when getting the latest tab selection, I think that IDynamicTabListSection and IDynamicTabListContentProvider should be used as the same as overrideTabs method for dynamic tab support.

Anthony has already known this problem.


TabbedPropertySheetPage --------------------------------------------------------

private int getLastTabSelection(IWorkbenchPart part, ISelection input) {
	TabDescriptor[] descriptors = registry.getTabDescriptors(part, input);
	if (descriptors.length != 0) {
		for (Iterator iter = selectionQueue.iterator(); iter.hasNext();) {
			String text = (String) iter.next();
			for (int i = 0; i < descriptors.length; i++) {
				if (text.equals(descriptors[i].getLabel())) {
					return i;
				}
			}
		}
	}
	return 0;
}


TabbedPropertyRegistry ---------------------------------------------------------

public TabDescriptor[] getTabDescriptors(IWorkbenchPart part,
		ISelection selection) {
	if (selection == null || selection.isEmpty())
		return EMPTY_DESCRIPTOR_ARRAY;

	TabDescriptor[] allDescriptors = getAllTabDescriptors();
	TabDescriptor[] result = filterTabDescriptors(allDescriptors, part,
		selection);
	return result;
}

protected TabDescriptor[] getAllTabDescriptors() {
	if (tabDescriptors == null) {
		List temp = readTabDescriptors();
		populateWithSectionDescriptors(temp);
		temp = sortTabDescriptorsByCategory(temp);
		temp = sortTabDescriptorsByAfterTab(temp);
		tabDescriptors = (TabDescriptor[]) temp
			.toArray(new TabDescriptor[temp.size()]);
	}
	return tabDescriptors;
}