Bug 131931 - [var] Variables view should offer Auto-Expand
Summary: [var] Variables view should offer Auto-Expand
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P2 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 129787 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-03-15 09:37 EST by Dani Megert CLA
Modified: 2021-09-07 02:39 EDT (History)
7 users (show)

See Also:


Attachments
patch (13.37 KB, patch)
2007-08-22 16:07 EDT, Darin Wright CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2006-03-15 09:37:49 EST
I200603014-1200

The new Variables view has the same usability problem for me like the old one: I constantly find myself expanding some nodes.

I'd like to see an auto-expand feature which lets me specify the auto-expansion level.
Comment 1 Darin Wright CLA 2006-03-15 10:19:06 EST
Deferred for future consideration.

(Note - columns support in the variables view is optional - you can turn if off via "Layout > Show Columns". So, the "new" view is still the "old" view. Of course, neither one has an auto expand level :-)
Comment 2 Dani Megert CLA 2006-06-16 10:59:10 EDT
And here's my final wish for 3.3 ;-)
Comment 3 Dani Megert CLA 2006-07-17 08:55:21 EDT
This bug was discussed during the JDT Summit: the idea is to add an option (slider?) to the Variables view that allows to specify the expand level. Max. would mean "expand all".
Comment 4 Darin Wright CLA 2007-03-22 16:56:25 EDT
Dani, I would like to defer this for post 3.3.
Comment 5 Dani Megert CLA 2007-03-22 16:59:50 EDT
That's fine with me.
Comment 6 Darin Wright CLA 2007-03-22 21:54:54 EDT
Thanks, marking as later.
Comment 7 Dani Megert CLA 2007-06-14 09:57:58 EDT
Can we reconsider for 3.4?
Comment 8 Darin Wright CLA 2007-06-14 10:09:22 EDT
This will take some experimentation with the virtual viewer - we can't actually expand until we retrieve data for a node in the tree, and know whether it is expandable. This may cause some expanding in the tree as you scroll, since we only retrieve data for visibile nodes.

I think that we can only allow for an expansion level rather than "max == expand all", since there can be recursive data structures.
Comment 9 Darin Wright CLA 2007-08-15 16:06:21 EDT
Now that bug 200105 is fixed, we can use the auto expand support in the asynch viewer. However, we have to be careful, as the var view already saves/restores expansion state for frames within a debug session, and the two mechanims could step on each other (i.e. If there is an auto expand level but the user has collapsed specific items, those items would get re-expanded when the user enters that frame).
Comment 10 Curtis Windatt CLA 2007-08-20 13:45:06 EDT
*** Bug 129787 has been marked as a duplicate of this bug. ***
Comment 11 Darin Wright CLA 2007-08-21 17:59:15 EDT
Released initial implementation to HEAD. Use the "Auto Expand..." action in the view drop down menu to set the level. Needs some more testing.
Comment 12 Michael Rennie CLA 2007-08-22 15:48:16 EDT
Trying to use logical structures with auto expand caused the view to freeze and do the 'forever trying to expand an item with no children' dance (in Linux). Also if I turn on show References and try to auto-expand to anything greater than 10, my computer falls asleep.
Comment 13 Darin Wright CLA 2007-08-22 16:03:45 EDT
There are other problems as well:
* If the user manually collapses vars, then steps - the vars re-expand
* if "show references" is on, and the expand level is deep enough, expanding is really slow
* expanding is "virtual" - it only works on items that get realized in the tree - so it also turns out to be incremental as your scroll... so the scroll bar does not show the entire picutre until more is relvealed.

I pulled the feature from HEAD as it does not seem to play well in the virtual viewer.
Comment 14 Darin Wright CLA 2007-08-22 16:07:52 EDT
Created attachment 76699 [details]
patch

work as a patch
Comment 15 Darin Wright CLA 2007-08-22 16:10:29 EDT
Dani - is there something you specfically want to expand? Like "this", or a specific variable in a loop? etc? Maybe there is another solution that we can find to address the problem.
Comment 16 Dani Megert CLA 2007-08-23 11:47:03 EDT
I'll see when I miss it next time. Now that it remembers expansion state I run into this less often.
Comment 17 Darin Wright CLA 2007-09-24 11:58:41 EDT
Not committed for 3.4
Comment 18 Dani Megert CLA 2008-06-10 04:04:35 EDT
This is still an issue for me: the very first time it stops somewhere all variables are collapsed and for me the 80% case is that I have to expand them at least one level (especially true for 'this').
Comment 19 Lars Vogel CLA 2019-11-14 02:15:13 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.
Comment 20 Alexander Veit CLA 2021-09-06 09:38:41 EDT
The problem still exists in Eclipse 2021-06.

If find myself on a breakpoint in a loop having expanded an instance attribute of the class that contains the loop.

After resuming and hitting the breakpoint again I have to expand the object graph again, and again,...
Comment 21 Sarika Sinha CLA 2021-09-07 02:39:50 EDT
Reopening !