Description James D. Miles 2006-03-13 20:54:57 EST

Overview: When new sites are created only the policy USER-EXCLUDE is used. There should be a choice.

Steps to Reproduce:
1. Start Eclipse 3.2M5 sdk.
2. Shutdown Eclipse
3. Change the platform.xml from
<site enabled="true" policy="USER-EXCLUDE" updateable="true" url="platform:/base/">
to 
<site enabled="true" policy="MANAGED-ONLY" updateable="true" url="platform:/base/">
4. Restart eclipse
5. You will see some jdt errors if you have the console open. These are not related to this bug.
6. Help->Software Updates->Find and install
7. Search for new features to install
8. Add a new local site to sites to search. I used the xyz sample site created by cheatsheet.
9. Finish
10. Select xyz feature to install
11.On the install page of wizard select "Change Location" button.
12. On the New Update Site Dialog choose "Add Location"
13. Browse to a new site to be added.
14. OK. Finish install.
15. After eclipse has restarted, check the platform.xml the new site will be using USER-EXCLUDE
<site enabled="true" policy="USER-EXCLUDE" updateable="true" url="file:../../../ctemp/eclipse/">
<feature id="com.example.xyz" url="features/com.example.xyz_2.0.0/" version="2.0.0">
</feature>
</site>

EXPECTED RESULTS: Since I am using the policy MANAGED-ONLY I would expect that any new sites created would be using this policy.

I have provided a patch with this bug. Since for MANAGED-ONLY we are always providing a platform.xml the change in policy does not need to happen until after the platform.xml is parsed. However this patch makes an assumption. The DTD allows each site to specify its own policy. My assumption is that if we are using MANAGED-ONLY we will want all sites to be that policy. So to set the default policy only the first site is checked for its policy. If the policy is MANAGED-ONLY for this site the default policy is set to MANAGED-ONLY.

If this is not satisfactory I can provide a different patch that reads the default policy from a preference.