Bug 131435 - [DataBinding] Support for StyledText
Summary: [DataBinding] Support for StyledText
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2006-03-11 14:51 EST by Aaron Digulla CLA
Modified: 2009-01-21 20:57 EST (History)
4 users (show)

See Also:


Attachments
StyledText patch (7.00 KB, patch)
2006-03-11 14:52 EST, Aaron Digulla CLA
no flags Details | Diff
patch + tests (25.39 KB, patch)
2008-09-05 17:06 EDT, Chris Aniszczyk CLA
no flags Details | Diff
mylyn/context/zip (1.49 KB, application/octet-stream)
2008-09-05 17:06 EDT, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Digulla CLA 2006-03-11 14:51:04 EST
Here is a patch to make StyledText work as an UI element
Comment 1 Aaron Digulla CLA 2006-03-11 14:52:37 EST
Created attachment 36093 [details]
StyledText patch
Comment 2 Boris Bokowski CLA 2007-06-27 11:22:28 EDT
Sorry for not picking it up at the time you filed the bug - this must have fallen through the cracks somehow.  Would you be interested in updating your patch to the new API?
Comment 3 Boris Bokowski CLA 2007-09-27 10:29:13 EDT
ping
Comment 4 Chris Aniszczyk CLA 2008-09-05 17:06:06 EDT
Created attachment 111875 [details]
patch + tests

I needed to implement this for a client so I've taken the liberty of contributing back something. It is pretty much identical to the TextObservableValue but for StyledText. In the future, we may want to refactor things a bit possibly but right now, I don't see anything obvious hitting me.
Comment 5 Chris Aniszczyk CLA 2008-09-05 17:06:09 EDT
Created attachment 111876 [details]
mylyn/context/zip
Comment 6 Chris Aniszczyk CLA 2008-09-05 17:06:38 EDT
maybe M2 boris or M3?
Comment 7 Matthew Hall CLA 2008-09-05 17:36:32 EDT
+1 for zx's patch
Comment 8 Matthew Hall CLA 2008-09-11 20:21:41 EDT
Chris, I'm overhauling the SWT observables as part of bug 194734, and your patch will be obsolete after the patch for that bug is committed.  I've taken the liberty of porting your patch over to the properties API (I've been careful to preserve attribution comments).  It will be included in the next patch I post to bug 194734.
Comment 9 Chris Aniszczyk CLA 2008-09-12 10:31:37 EDT
(In reply to comment #8)
> Chris, I'm overhauling the SWT observables as part of bug 194734, and your
> patch will be obsolete after the patch for that bug is committed.  I've taken
> the liberty of porting your patch over to the properties API (I've been careful
> to preserve attribution comments).  It will be included in the next patch I
> post to bug 194734.

Thanks Matt.
Comment 10 Matthew Hall CLA 2009-01-21 20:57:43 EST
Released to HEAD > 20090120 as part of bug 194734