Bug 131416 - [OLE] WorkbenchPart.setPartName public, please
Summary: [OLE] WorkbenchPart.setPartName public, please
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2006-03-10 18:40 EST by benson margulies CLA
Modified: 2019-09-06 15:36 EDT (History)
0 users

See Also:


Attachments
Modified to notice modifications. (23.49 KB, text/plain)
2007-06-25 14:42 EDT, benson margulies CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description benson margulies CLA 2006-03-10 18:40:34 EST
I've got an application where I'm using the OleEditor to show a file in Eclipse. I would badly like to control the name shown as the part name. For editors under my control, it's no problem -- I call setPartName and all is well.

However, OleEditor does not belong to me, and I can't even derive a subclass without nefarious tactics. So I'm stuck with the standard part name. It seems to me that making this public would be a harmless addition of flexibility.
Comment 1 Tod Creasey CLA 2006-03-13 10:01:16 EST
We avoid making this public so that the editor determines its name rather than another plug-in. I would think making OleEditor public would be more what you were after.

Note that the 3.2 API freeze has passed.
Comment 2 benson margulies CLA 2006-03-13 10:03:09 EST
I agree. It seems really like a good idea to me to publicize that class; it's full of special cases that we might want to tweak, tune, or adjust. A pity that this can't be snuck into 3.2. Luckily, it's pretty self-contained and I can make a copy.
Comment 3 Eric Moffatt CLA 2007-06-25 14:37:20 EDT
Benson, does your copy work? I ask because we're having -real- issues here with getting the container/editor/site all playing together correctly (we're short on OLE smarts...;-).

If you can provide hints on what's wrong with our setup (a patch perhaps..;-) I'd -really- appreciate it (think at minimum a public attribution, eclipse shirt (even if I have to give you mine) and libations whenever we can get together...
 
Comment 4 benson margulies CLA 2007-06-25 14:41:44 EDT
I did make a local mod to resolve an issue with event management and noticing modifications. I don't know what version I modified, so rather than I patch I'm going to attach the whole thing.
Comment 5 benson margulies CLA 2007-06-25 14:42:18 EDT
Created attachment 72391 [details]
Modified to notice modifications.
Comment 6 benson margulies CLA 2007-06-25 14:57:24 EDT
I want to emphasize that, back in 3.1.1 where I was working with this, the only problem I had was the lack of event management resulting in a failure to track mods inside Word with the Editor dirty flag -- plus I wanted to control the decoration. If you all are having other more exotic problems i don't know what to recommend.
Comment 7 Eclipse Webmaster CLA 2019-09-06 15:36:50 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.