Bug 131265 - Make ExpandBar background changeable by users
Summary: Make ExpandBar background changeable by users
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Felipe Heidrich CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-10 01:48 EST by Tony Lam CLA
Modified: 2006-04-26 15:18 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Lam CLA 2006-03-10 01:48:26 EST
The ExpandBar that is introduced in Eclipse 3.2 M5 provides a Windows Explorer like bar widget.  The background of this SWT widget has linked to Windows theme, so that it changes based on Windows user setting.  Although ExpandBar provides set background methods, running ExpandBar.setBackground(Color) has no effect on UI.  However some SWT based applications, including my current RCP project, may use ExpandBar for different purpose (ie rather than as a Windows Explorer style bar).  setBackground() should guarantee the effect of setting background.  If users want to stick with the current behaviour as in Eclipse M5 (or vice versa), they should be able to do this via adding a SWT flag to the constructor.  Allowing user to set ExpandBar's background can encourage the use of ExpandBar as a general purpose widget.
Comment 1 Steve Northover CLA 2006-03-13 21:41:51 EST
This sounds reasonable to me.  If the programmer sets the background, we could stop drawing with the theme.
Comment 2 Felipe Heidrich CLA 2006-03-14 12:14:00 EST
What about setForeground() and setFont() ?
Tony: do you need foreground and font too ?
Steve: since you are okay not using the theme to draw background we can extent the idea to foregrond and font I suppose.
Comment 3 Steve Northover CLA 2006-03-14 12:15:20 EST
Yes.  AS soon as the guy touches these, he is not longer using the theme.
Comment 4 Tony Lam CLA 2006-03-14 17:12:48 EST
Felipe, I have not yet touched on setForeground() and setFont().  I agree on Steve's comment that the default appearance should be changeable under this unusual scenario.
Comment 5 Felipe Heidrich CLA 2006-04-19 11:43:05 EDT
fixed in HEAD > 20060418