Bug 130979 - [Common Navigator] Provide access to INavigatorContentExtension by id
Summary: [Common Navigator] Provide access to INavigatorContentExtension by id
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Michael D. Elder CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2006-03-08 15:48 EST by Michael Valenta CLA
Modified: 2006-05-04 17:12 EDT (History)
7 users (show)

See Also:


Attachments
Promotes getContentExtensionById() to API from NavigatorContentService to INavigatorContentService (2.19 KB, patch)
2006-05-01 10:51 EDT, Michael D. Elder CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2006-03-08 15:48:04 EST
It would be nice if we could obtain an INavigatorContentExtension by id from the INavigatorContentService. The reason I ask is I needed to access a content provider from an action provider. I was able to work around this so it is not needed for 3.2 but I think it would be generally useful.
Comment 1 Michael D. Elder CLA 2006-03-28 15:48:36 EST
I agree that this would useful. Since it's not required for your use case, I am going to defer this to 3.3. 
Comment 2 Michael D. Elder CLA 2006-05-01 10:50:47 EDT
Other use cases from contributors make this a useful, non-breaking, low-risk addition to the API. The method is already available on the underlying implementation, this will provide clients an official means to it and avoid dependencies to the internal implementation. 
Comment 3 Michael D. Elder CLA 2006-05-01 10:51:51 EDT
Created attachment 39939 [details]
Promotes getContentExtensionById() to API from NavigatorContentService to INavigatorContentService
Comment 4 Boris Bokowski CLA 2006-05-01 11:09:37 EDT
Michael, could you describe the other use cases? Is there a workaround?
Comment 5 Michael D. Elder CLA 2006-05-01 13:09:13 EDT
Other use cases include where a client wants to extend or override an existing content extension, without a direct dependency to that extension. Clients want to be able to delegate to the content or label provider of an overridden extension, without a direct dependency to the content/label provider. To do this, they must be able to access the instance created by the content service. Currently, there is no effective workaround that does not require referencing the internal API.
Comment 6 Michael D. Elder CLA 2006-05-02 16:42:24 EDT
Will this be approved for RC3?
Comment 7 Mike Wilson CLA 2006-05-03 09:44:38 EDT
+1 PMC approval to add the API. you still need two component leads (not including me) to say yes to making the change.
Comment 8 Michael D. Elder CLA 2006-05-03 13:43:29 EDT
Can this be approved in time to be included in the next Platform/UI build submission (3:30 today)?
Comment 9 Michael Valenta CLA 2006-05-03 14:27:24 EDT
+1
Comment 10 Michael D. Elder CLA 2006-05-03 14:58:16 EDT
Tod, does this look okay for RC3?
Comment 11 Jeff McAffer CLA 2006-05-04 10:20:44 EDT
the JAva doc for these method should have a description.  The first line of the Javadoc comment shows up in the method summary.

+1 with updated comments.
Comment 12 Michael D. Elder CLA 2006-05-04 10:42:26 EDT
Fixed and released.