Community
Participate
Working Groups
20020404 DebugActionGroups allow plugins to specify the visiblility of actions in the toolbar and popup menus of "debug" views. In DebugActionGroupsManager#updateDebugActionGroups, we change the visiblity of contributed items in the toolbar retrieved via: IActionBars actionBars = viewPart.getViewSite().getActionBars(); //the isvToolBarMgr IToolBarManager toolBarManager = actionBars.getToolBarManager(); It appears that the wrong toolBarManager is marked as dirty. In ViewPane#updateActionBars(), the viewToolBarManager is marked as dirty but the isvToolBarMgr is not. Therefore the visibility changes are not shown in the toolbar. To fix the problem, we must now explicitly mark the isvToolBarManager as dirty. Previously this was not necessary (I believe in builds < 20020402).
Changing visibility on an item does not mark the manager as dirty. Is it possible you were adding/removing items previously?
AFAIK, we have only ever set the visibility. No problem...I will release fix in our code.
There have been some interesting changes in this area. If you have the time to step through it, it would be helpful. But ContributionItem.setVisible just sets the field, and this hasn't changed recently.
Have you been able to step thru the code to determine what is going on? If so, can this be closed now or have you identified a problem area?
Simon, I will have to take a look at this next week. I am away from a computer for the next 4 days and I don't remember the specifics from April ;-)
I would propose this be changed to a feature request...changing the visibility of an contributed item would flag the toolbar manager as dirty.
Moving Dougs bugs
Assigning to component owner PW
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
