Bug 130686 - Request for an Aggregate builder in BIRT report designer
Summary: Request for an Aggregate builder in BIRT report designer
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: 2.2.0 RC2   Edit
Assignee: Ivy Li CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on: 186971
Blocks: 187178 187496 187752 189358
  Show dependency tree
 
Reported: 2006-03-06 22:11 EST by Gary Xue CLA
Modified: 2007-06-18 18:22 EDT (History)
4 users (show)

See Also:


Attachments
Move the Total from BIRT functions to main Category aggregates (18.05 KB, image/gif)
2006-03-28 15:13 EST, Aashima Goel CLA
no flags Details
aggregation builder UI (209.43 KB, application/pdf)
2007-04-30 17:17 EDT, Aashima Goel CLA
no flags Details
Updated UI on aggregation builder (221.86 KB, application/pdf)
2007-05-10 14:39 EDT, Aashima Goel CLA
no flags Details
revised with minor changes (227.03 KB, application/pdf)
2007-05-10 18:37 EDT, Aashima Goel CLA
no flags Details
Mockup of the current implementation (35.42 KB, image/png)
2007-05-30 14:55 EDT, Rima Kanguri CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gary Xue CLA 2006-03-06 22:11:03 EST
It is somewhat difficult for a new BIRT user to figure out how to build an aggregate without reading the help or looking at examples. It's even more difficult to build an advanced aggregate (those that take advantage of filtering and non-default groupin. The issues are:
(1) Aggregates are buried under BIRT functions/Total object in Expression builder. A novice may not be able to immediately locate this when he needs an aggregate.
(2) The filter and group parameters are difficult to figure out without help.

We should consider adding an aggregate builder to the Expression Builder. Some usability study is needed to figure out the exact UI, but I suggest the following guidelines:

* Expression builder should list Aggregates as a top level construct (alongside operators/functions/data sets etc) rather than listing them under functions.

* When an aggregate is selected, the builder should have a dialog to help the user construct the various arguments to the aggregate function, including (1) picking a column (or build an expression) to aggregate on; (2) Pick a group from a list of available groups; (3) build a filter expression
Comment 1 Wenfeng Li CLA 2006-03-06 22:16:17 EST
schedule to RC0 to list Aggregates as a top level construct and creating a mock up for the rest of enhancements. 
Comment 2 Aashima Goel CLA 2006-03-28 15:13:19 EST
Created attachment 37134 [details]
Move the Total from BIRT functions to main Category aggregates

In Expression Builder, Birt Functions, Move the 'Total' and its expressions to a new category called 'Aggregates'(see mockup).
Comment 3 Aashima Goel CLA 2006-03-28 15:15:07 EST
aggregate builder is being discussed. Most likely future milestone will have the implementation.
Comment 4 Wang Qiangsheng CLA 2006-03-29 01:48:22 EST
Please take care of this changes when implment data binding.
Comment 5 Wenfeng Li CLA 2006-04-07 02:49:23 EDT
please see the attached mock up.
Comment 6 Wang Qiangsheng CLA 2006-04-09 21:26:58 EDT
As comments #3, we already changed the thing in the mockup.
The further research need to be done by GUI designer.
Comment 7 Wenfeng Li CLA 2006-04-17 21:46:55 EDT
Synch up with Callisto schedule to rename RC1 as RC2 targeted 5/5/2006.
Comment 8 Rima Kanguri CLA 2007-04-06 19:34:24 EDT
For the the UI part i have been thinking of the following.
---------------------------------------------------------
- Add a new item in palette "Σ" under a new category 
- When user drags and drops the item from palette to the table layout view, show the new aggregation builder
- Note the aggregateOn property is decided based on which area the user drops the aggregation function like table header/footter, group header/footer
- THe new aggregation builder allows user to specify the name, functiona name, data type etc for the aggregation.
- At the end of this UI operation, a new data item with a corresponding data binding column is created.



Reassigning to Aashima for the UI mockups.
Comment 9 Rima Kanguri CLA 2007-04-06 19:40:31 EDT
- One clarification add symbol Σ ( signma) to indicate its aggregation.
- I have asked Bang to use the same idea for cross tab too, it is still under discussion.
Comment 10 Aashima Goel CLA 2007-04-30 17:17:26 EDT
Created attachment 65431 [details]
aggregation builder UI
Comment 11 Aashima Goel CLA 2007-05-10 14:39:21 EDT
Created attachment 66741 [details]
Updated UI on aggregation builder
Comment 12 Aashima Goel CLA 2007-05-10 18:37:19 EDT
Created attachment 66784 [details]
revised with minor changes
Comment 13 Chen Chao CLA 2007-05-15 06:14:31 EDT
GUI couldn't get the argment list for a purticular function name. Currently
Model does not have any information of those function definitions. 
Comment 14 Yuejie Chen CLA 2007-05-24 02:27:06 EDT
Dateset aggregation builder is not same as column binding aggregation builder.
Comment 15 Rima Kanguri CLA 2007-05-24 14:42:54 EDT
Please can you clarify which page number in the latest mockup attached are you talking about. It should be the same.
Comment 16 Yuejie Chen CLA 2007-05-25 01:39:26 EDT
Fixed
Comment 17 Rima Kanguri CLA 2007-05-29 15:29:33 EDT
Please refer to the mockup attached by Aashima in comment #12, The UI is not implemented as mocked up

I am reopening the bug, as this the UI is not consistent witht he mockup.
Comment 18 Aashima Goel CLA 2007-05-29 15:31:40 EDT
see page 17 of the document
Comment 19 Yuejie Chen CLA 2007-05-29 23:00:00 EDT
I have do it as the mockup described. But the actually result is not same as the scenario used in mockup. In the mockup, the SUM function does not have arguments, but in reality, the SUM function has 3 arguments(we fetch the function and it's arguments from model API), so it looks not consistent with the mockup.

Please see page 4 and page 6 of the spec.
Comment 20 Rima Kanguri CLA 2007-05-30 14:47:58 EDT
Qiangsheng,

The issue with both the bugs is same the UI is not implemented as mocked up.
Please refer to the attachments of this email
- Firstly UI should not show groupName, filter and expression ( its redundant ) Example when SUM function is selected there are no parameters Looks like from Xiong's comments model is returning 3 parameters for SUM, i.e expression, group, filter.
- We need to fix this, either model should be changed or UI should ignore filter, group and expression in the arguments

I am reopening both these bugs


Comment 21 Rima Kanguri CLA 2007-05-30 14:55:17 EDT
Created attachment 69359 [details]
Mockup of the current implementation

Please refer to the comments in hte mockup for what is missing. Thanks.
Comment 22 Rima Kanguri CLA 2007-05-30 14:56:16 EDT
Reopening bug as already mentioned in email.
Comment 23 Yuejie Chen CLA 2007-05-30 23:00:16 EDT
(In reply to comment #21)
> Created an attachment (id=69359) [details]
> Mockup of the current implementation
> 
> Please refer to the comments in hte mockup for what is missing. Thanks.
> 

The three fields you pointed out in the attached file are dynamically generated by selected function, the model API return the three arguments for the function SUM, so GUI display these fields. GUI did not hard code to display these fields, and i think we should not filter these fields on GUI side, so i reassign to model team.
Comment 24 Yuejie Chen CLA 2007-05-30 23:03:24 EDT
The title issue has fixed by 189358
Comment 25 Ivy Li CLA 2007-05-31 03:31:06 EDT
Fixed.
Comment 26 Aashima Goel CLA 2007-05-31 13:51:28 EDT
I am using May 31 build. The changes to aggregation builder dialog have not yet been fixed completely. Still some extra fields are seen.
1. We do not need 'expr' field.
2. Filter label should read 'Filter condition'

Please see attachment 69359 [details]

Same changes apply to x Tab aggregation builder also.
Please reopen the bug

 

Comment 27 Rima Kanguri CLA 2007-05-31 14:01:20 EDT
Looks like the expression field is still shown as an argument of the all the functions. 
Comment 28 Ivy Li CLA 2007-05-31 23:25:15 EDT
We've checked this bug yesterday. Verify with QA, there is no expression in today's build. 
Comment 29 Aashima Goel CLA 2007-06-01 12:38:31 EDT
verified.
Build id: v20070601-0630
Comment 30 Krishna Venkatraman CLA 2007-06-18 18:22:03 EDT
Added this to the 2.2 plan.