Bug 130667 - "Select required" does not pick all the necessary features
Summary: "Select required" does not pick all the necessary features
Status: RESOLVED DUPLICATE of bug 138802
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Branko Tripkovic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-06 17:54 EST by Pascal Rapicault CLA
Modified: 2006-05-04 08:17 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2006-03-06 17:54:16 EST
I20060301-0800
Select WTP (notice JEM is missing), click "select required", notice that when it returns the dependency is still not satisfied. If you select the VE feature then the dependecy is satisfied.
Comment 1 Pascal Rapicault CLA 2006-03-06 18:28:30 EST
I have investigated a bit further and the problem is coming from the UI part of the code:
- WTP needs JEM
- JEM is a feature included in VE.
- The computation to find which features are missing is done properly (the code ((OperationValidator)OperationsManager.getValidator()).getRequiredFeatures(jobs); does return JEM, EMF and a few other features to install)
- Based on the features previously returned, there is a bit of UI code that iterates over all the features to decide where to put the checky box. The problem is that this code only look at the id of the features and because JEM is not listed in the dialog (and does not need to) it does not get selected.
Comment 2 Pascal Rapicault CLA 2006-03-29 08:54:24 EST
A bit more clarification on my previous post.
- given the code, JEM could not be selected because it does not appear in the site.xml, and the search does not consult the included features of the feature listed in the dialog.

For Callisto this problem has been solved by adding the necessary feature in the site.xml in a "random stuffs" category so that the user is not confused with too many features.
In short I think we don't need to fix this for 3.2.
Comment 3 Jeff McAffer CLA 2006-05-04 00:10:45 EDT
as per commetn 2, do we still need to do this for 3.2?
Comment 4 Dejan Glozic CLA 2006-05-04 07:57:37 EDT

*** This bug has been marked as a duplicate of 138802 ***
Comment 5 Branko Tripkovic CLA 2006-05-04 08:17:09 EDT
Jeff,
I was not gunning just for this bug but fixing bug 138802 meant that “Select Required” just did not work. And in the course of fixing that bug this bug got fixed too. Which was just an added bonus.