Bug 130489 - [Help] Could not get results from extradir when searching with search scope
Summary: [Help] Could not get results from extradir when searching with search scope
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Curtis d'Entremont CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-03-05 20:50 EST by Jiang Lin Quan CLA
Modified: 2007-06-05 19:29 EDT (History)
1 user (show)

See Also:

Attachments
patch for this defect (4.61 KB, patch)
2006-04-04 05:21 EDT, Jiang Lin Quan CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiang Lin Quan CLA 2006-03-05 20:50:38 EST 
<<Steps To Reproduce>>
1, Launch the Help with sample extradir plugin in attachment.
2, Create a search scope containing the sample book.
3, search "extradir" for results.

<<Actual Result>>
No results returned.

<<Expected Result>>
All results in extradir should be searched.

<<Cause>>
There are no codes to cope with extradir working with search scope.

<<Solution>>
Add the codes.
Comment 1 Jiang Lin Quan CLA 2006-04-04 05:21:32 EDT 
Created attachment 37590 [details]
patch for this defect
Comment 2 Curtis d'Entremont CLA 2006-05-30 17:19:21 EDT 
Patch applied to 3.3 branch. Nice patch.

I wrote some JUnit tests, ran them before patch and they failed, after patch they passed. Code looks fine.
Comment 3 John Arthorne CLA 2006-06-12 17:15:50 EDT 
Moving to new M1 milestone
Comment 4 Mark Melvin CLA 2007-03-08 11:51:22 EST 
Was there supposed to be another attachment here?  I am having an issue with no results returned in any search scopes and I am wondering if it is the same bug.  I am not defining an extradir so I am unsure if this is the same issue or not.
Comment 5 Curtis d'Entremont CLA 2007-03-08 12:38:33 EST 
Sounds like a different issue. This one was only affecting extraDir content associated with a toc.
Comment 6 Mark Melvin CLA 2007-03-08 13:05:21 EST 
I'll file a new issue as I am pretty sure this is an Eclipse regression from 3.2.1 to 3.2.2.
Comment 7 Mark Melvin CLA 2007-03-08 13:07:27 EST 
Sorry.  I had my logic inverted in my head... ;o)  

It actually still does it on 3.2.1, so it must be due to a recent change in my plugin structure - not due to Eclipse.  I'll post on the platform newsgroup first.