Community
Participate
Working Groups
I20060223-1656 After running for about a day, I made a memory snapshot of my development Eclipse (ZRH plugins from CVS, dependencies imported as binary). I found 3 instances of RemoteLogOperation.LogEntryCache, which retained 6.2MB, 12.8MB, and 2KB of memory. As far as I see as a user, log entries are only cached for the active editor and the changes in the Synchronize view. I had no editor open and 4 incoming and 8 outgoing changes. => I guess there are a lot more entries retained than required. Since a lot of these Strings are probably duplicates, if might be worth trying to share them to lower memory consumption.
We've done some priliminary profiling and haven't seen any leaks. We'll do another pass during the RC3 test pass to make sure.
Created attachment 40192 [details] Patch There was a leak. We were never clearing log entries that were no longer relevant.
+1 to adding the patch. please verify that this fixes the original problem.
Fixed reviewed by Bogdan and released. Bug 79697 is on this same subject and I have added a comment that more savings could be had by sharing strings.
+1