Description David Williams 2006-02-25 09:52:31 EST

I'm going by 
http://help.eclipse.org/help31/index.jsp?topic=/org.eclipse.platform.doc.isv/reference/misc/update_sitemap.html

was same in version 3.0. 

Plus, I'll make 4 enhancement suggestions. Even though some would, technically speaking, be API breaking change if anyone considers the documented DTD as API. 



1. To be considered valid, I suggest a site.xml needs to have at least 1 feature  ... so, 'feature+', instead of 'feature*'.

2. I suggest the order be spec'd as having category-def come before the features and archives, instead of being spec'd to come last 
(put's things in order of most general, to most specific, conceptually, and makes it easier to find in large site.xml files).

3. the patch attribte default value, "false", must be quoted.

4. the ws attribue really is not required, so should say #IMPLIED instead of #REQUIRED

5. Oh, and I also suggest it "say" its encoded in UTF-8, instead of ISO-8859-1, as being more customary (and ... if non ascii characters were ever used, you'd probably want UTF-8). 

6. Would be helpful if a "well known, standard eclipse" publicId was assigned to all such DTD's in Eclipse's spec's. And, also literally "hosted" somewhere on Eclipse so XML validators could work (more easily) with instance documents. See bug 116615 for related information (or, at least, sort of a similar case). 
For example, 

<!DOCTYPE site PUBLIC "-//Eclipse.org//DTD Eclipse Update 3.2.001 Compiler//EN" "http://www.eclipse.org/update/core/site.dtd">.