Bug 128888 - View Toolbars no longer wrap
Summary: View Toolbars no longer wrap
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on: 123257
Blocks:
  Show dependency tree
 
Reported: 2006-02-21 15:59 EST by Michael Van Meekeren CLA
Modified: 2006-04-03 10:52 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Van Meekeren CLA 2006-02-21 15:59:33 EST 
I seems that some time in the last few integration builds we have broken the wrapping of view toolbars.  This might have something to do with the new layout.

In either case it is quite a regression and needs to be fixed.
Comment 1 Eric Moffatt CLA 2006-02-28 11:12:16 EST 
Mvm, I can't think of how the trim work would affect the tool display on a view stack. I haven't even changed the main CoolBar yet...

It is indeed broken though (just checked against 3.1 using the outline view).
Comment 2 Michael Van Meekeren CLA 2006-03-01 09:17:19 EST 
maybe we should just try process of elimination and find out when this stopped working then browse changes in the toolbar code
Comment 3 Dani Megert CLA 2006-03-27 09:25:48 EST 
This should be looked at for 3.2. See also bug 122639 which might be related and is on the polish list.
Comment 4 Eric Moffatt CLA 2006-03-27 14:26:44 EST 
This appears to have been intro'd during the changes between 1.100 & 1.101 which introduced the ability to supply 'custom' ToolBars. We've apparently dropped the 'SWT.WRAP' style bit.

My guess is that we need to add 'SWT.WRAP' in 'DefaultActionBarPresentationFactory.createViewToolBarManager'...Nick?
Comment 5 Eric Moffatt CLA 2006-03-27 14:39:21 EST 
This appears to have been done to satisfy bug 123257. I'll re-open that defect so that Matt can ensure that my mods haven't adversely affected his code...
Comment 6 Eric Moffatt CLA 2006-03-27 15:20:11 EST 
Committed in >20060327. Added SWT.WRAP to -both- toolbar creation methods.

BTW, the 1.100 / 1.101 in comment 4 was to the ViewPane's history...
Comment 7 Eric Moffatt CLA 2006-03-28 13:38:16 EST 
Verified in I20060328-0010.
Comment 8 Michael Van Meekeren CLA 2006-03-29 10:34:08 EST 
reopening until we verify that SWT.WRAP is what we want for  -both- toolbar creation methods.  What we should likely do is do what we used to do.
Comment 9 Eric Moffatt CLA 2006-03-29 11:40:13 EST 
Mvm, I'd already re-opened bug 123257 to cover this. Do we want both defects open?
Comment 10 Michael Van Meekeren CLA 2006-03-29 12:14:04 EST 
My point is that by putting wrap in for both bars you may have introduced a regression from 3.1 as well.
Comment 11 Eric Moffatt CLA 2006-03-30 16:17:14 EST 
Committed in >20060330. 

Removed the SWT.WRAP from the non-View toolbars to match 3.1 behaviour.
Comment 12 Eric Moffatt CLA 2006-04-03 10:52:52 EDT 
Verified in 3.2 M6...