Bug 128738 - Program argument changes don't take
Summary: Program argument changes don't take
Status: CLOSED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: jst.server (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0 M1   Edit
Assignee: Gorkem Ercan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 157645 162811 169936 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-02-20 20:04 EST by Wayne Beaton CLA
Modified: 2017-10-11 16:08 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Beaton CLA 2006-02-20 20:04:56 EST
I created an IBM WebSphere 6 Server mapping, but specified the cell name incorrectly. I opened the editor on the configuration and clicked "Open Launch Configuration". In the "Properties for IBM WebSphere 6" dialog, I switch to the "Arguments" page and changed the incorrectly-specified cell name to the correct value. I click "Apply", then "Okay" (effect is the same when I don't click "Apply" first). I close the window and reopen (by clicking "Open Launch Configuration"). The original text remains (i.e. my changes are gone).

If I add to the end of the Program arguments, the change does remain. Any changes I attempt to make anywhere in the existing value are discarded (at least every combination that I've tried).

I also tried this by going through the Run Configuration dialog ("Run > Run..."). Same effect.

I can provide screen shots if you think this would be valuable.

For kicks, I created a Tomcat server and tried messing around with it to see if it has similar problems. The value for Tomcat is simply "start". If I add text to the end, it retains the changes. If I change the word "start", it appends the word "start" after my changes the next time I open the window. I can show this if you'd like, but the changes I'm making don't really make any sense, so I don't know how valuable screen shots will be.
Comment 1 Gorkem Ercan CLA 2006-02-21 02:55:01 EST
For the generic servers, including websphere adapter this is the expected behavior(although not the right one). The problem is initially the arguments were treated by the generic server framework as a long string so detecting the changes in the middle required very ugly methods. After the 0.7 release I have added the possibility to add the arguments seperately(some work left for 1.5 as well) into framework but for backward compatability reasons the long string option is still supported. Most of the server adapters(if not all) use the old way which result in the behavior you have described. 
Comment 2 Gorkem Ercan CLA 2006-10-09 16:44:08 EDT
*** Bug 157645 has been marked as a duplicate of this bug. ***
Comment 3 Gorkem Ercan CLA 2006-10-31 16:18:33 EST
*** Bug 162811 has been marked as a duplicate of this bug. ***
Comment 4 Gabriele Garuglieri CLA 2006-11-01 12:41:10 EST
Any plan to solve this problem? We are already to 1.5.1 and the server support is still not usable.
We need to use a jboss configuration with non standard ports and we need to pass some properties at startup, but launch config and server definition are always reset to default each time we start the server or open launch configuration.
Pls could you raise the severity/priority of this bug?

Thanks,  Gabriele
Comment 5 Gorkem Ercan CLA 2006-12-24 05:21:21 EST
Fixed on the HEAD and will release for the 2.0 stream. With this fix VM and program arguments are never recreated 
Comment 6 Gorkem Ercan CLA 2006-12-24 05:21:50 EST
resolving
Comment 7 Gorkem Ercan CLA 2007-01-27 10:30:11 EST
*** Bug 169936 has been marked as a duplicate of this bug. ***
Comment 8 John Lanuti CLA 2007-04-03 12:06:40 EDT
Closing as fixed since M1.
Comment 9 Eclipse Genie CLA 2017-10-11 16:08:06 EDT
New Gerrit change created: https://git.eclipse.org/r/108078