Bug 128670 - [Dialogs] StatusDialog adds 2 horizontal margins around button bar
Summary: [Dialogs] StatusDialog adds 2 horizontal margins around button bar
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2006-02-20 11:04 EST by Tobias Widmer CLA
Modified: 2006-04-18 13:38 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot (11.05 KB, image/png)
2006-02-20 11:05 EST, Tobias Widmer CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Widmer CLA 2006-02-20 11:04:53 EST 
I20060217-1115

The button bar of the history dialog should properly align the OK, Cancel and Help buttons.

Attaching screenshot...
Comment 1 Tobias Widmer CLA 2006-02-20 11:05:14 EST 
Created attachment 35011 [details]
Screenshot
Comment 2 Markus Keller CLA 2006-02-22 04:54:44 EST 
Moving to Platfom/UI.

The problem is in StatusDialog#createButtonBar(..):

    layout.marginWidth =
            convertHorizontalDLUsToPixels(IDialogConstants.HORIZONTAL_MARGIN);

This statement adds a second horizontal margin to the one from Dialog#createButtonBar(..) (called via 2 super.createButtonBar(..)).

This makes the Help and the OK button move too far away from the dialog's border. The fix is to replace the above line by:

    layout.marginWidth = 0;
Comment 3 Eric Moffatt CLA 2006-02-27 10:14:45 EST 
Over to you Karice...
Comment 4 Michael Van Meekeren CLA 2006-04-06 14:35:09 EDT 
Any plans to fix this for 3.2?
Comment 5 Susan McCourt CLA 2006-04-07 13:59:08 EDT 
marking this one for 3.2 since it affects so many dialogs.
Comment 6 Susan McCourt CLA 2006-04-17 18:09:03 EDT 
This was already included with Curtis' patch for bug #127658.