Bug 128455 - [Presentation] [ViewBar] Outline view toolbar is visible above a maximized editor
Summary: [Presentation] [ViewBar] Outline view toolbar is visible above a maximized ed...
Status: RESOLVED DUPLICATE of bug 122639
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal with 5 votes (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 116112 128435 128762 129802 134487 138584 140937 143919 147268 150119 150639 151372 163669 164234 171564 173833 173974 205353 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-02-17 14:16 EST by Hosam CLA
Modified: 2007-10-04 04:29 EDT (History)
36 users (show)

See Also:


Attachments
Screenshot for the bug (40.88 KB, image/png)
2006-02-17 14:18 EST, Hosam CLA
no flags Details
Another screenshot (42.82 KB, image/png)
2006-02-18 15:38 EST, Hosam CLA
no flags Details
Partial visibility patch (4.97 KB, patch)
2006-04-18 14:55 EDT, Paul Webster CLA
no flags Details | Diff
over-complicated test case :) (6.28 KB, application/octet-stream)
2006-09-30 16:49 EDT, Andrey Loskutov CLA
no flags Details
Same bug with 3.3RCs (26.87 KB, image/png)
2007-06-25 09:20 EDT, Genady Beryozkin CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hosam CLA 2006-02-17 14:16:35 EST
I'm attaching a screenshot.

As you can see in the upper right corner of the attachment, the toolbar of the outline view is visible over the maximized java editor.

Please feel free to change the summary if you find a better subject.
Comment 1 Hosam CLA 2006-02-17 14:18:06 EST
Created attachment 34939 [details]
Screenshot for the bug
Comment 2 Hosam CLA 2006-02-18 15:38:51 EST
Created attachment 34966 [details]
Another screenshot
Comment 3 Hosam CLA 2006-02-18 15:40:15 EST
(In reply to comment #2)
> Created an attachment (id=34966) [edit]
> Another screenshot
> 

It happened again today. This time I noticed that it happened right after I pressed Ctrl+S (save). It happened with the console view this time, so it's not limited to the outline view.
Comment 4 Kim Horne CLA 2006-02-20 09:12:25 EST
What build of 3.2 are you using?
Comment 5 Hosam CLA 2006-02-20 12:10:35 EST
(In reply to comment #4)
> What build of 3.2 are you using?
> 

3.2M5
Comment 6 Kim Horne CLA 2006-02-20 12:17:02 EST
Ahh it strikes again!
Comment 7 Paul Webster CLA 2006-02-20 12:33:13 EST
So I think that this is the same as bug 116112, but I'm not going to close it as a duplicate just yet (since I've already solved this bug twice!).

PW
Comment 8 Paul Webster CLA 2006-02-21 07:23:49 EST
And bug 128762 :-)

PW
Comment 9 Markus Keller CLA 2006-03-17 10:26:52 EST
(In reply to comment #8)
> And bug 128762 :-)

For me, this is more like a :-( than a :-).
See also bug 129802 for possible steps to reproduce.

Comment 10 Markus Keller CLA 2006-03-17 10:33:40 EST
Easy steps to reproduce in I20060315-1200:

- close Console view
- create a compilation unit like this:
package p;
public class Greeter {
	public static void main(String[] args) {
		System.out.println("Hello World");
	}
}

- maximize the editor, then choose Run As > Java Application

Depending on the available width at the view stack where the Console view shows up, you either get a floating view toolbar, or a floating Console text saying "Hello World".
Comment 11 Paul Webster CLA 2006-03-24 09:58:46 EST
(In reply to comment #10)

if the console view is open in another perspective ... if you close the view, see it in the debug perspective  and then run the app in the java perspective, the view artifacts show up in its "debug" location.  If you close the view and run in the java perspective, the view artifacts show up in its "java" location.

PW
Comment 12 Paul Webster CLA 2006-03-24 10:00:45 EST
Hosam, can you give me a use case that would help reproduce your case

I'm pursuing Markus' usecase, but that's when an action re-opens a view in this perspective when the view also is open in a different perspective.  I don't think this will cause the problem with the outline view.

PW
Comment 13 Dani Megert CLA 2006-03-25 01:52:47 EST
See also bug 129802 with simple steps to reproduce a similar left-over scenario.
Comment 14 Paul Webster CLA 2006-03-26 11:56:32 EST
*** Bug 129802 has been marked as a duplicate of this bug. ***
Comment 15 Paul Webster CLA 2006-03-26 12:07:50 EST
Released into HEAD >20060326

PW
Comment 16 Paul Webster CLA 2006-03-28 13:54:53 EST
It fails if the toolbar is on the second line instead of on the tab line.

PW
Comment 17 Paul Webster CLA 2006-04-03 13:28:13 EDT
*** Bug 134487 has been marked as a duplicate of this bug. ***
Comment 18 Paul Webster CLA 2006-04-04 12:54:25 EDT
*** Bug 116112 has been marked as a duplicate of this bug. ***
Comment 19 Paul Webster CLA 2006-04-04 13:03:57 EDT
*** Bug 128435 has been marked as a duplicate of this bug. ***
Comment 20 Paul Webster CLA 2006-04-16 08:26:41 EDT
It appears to be a condition of the proxy control for the centre of the view.  It saves a visible state of true, and as long as it's target control is null, it will never update that state.

When you maximize the editor, that boolean is still true.  When running an app creates the console eclipse adds the toolbar to the centre proxy, which immediately sets the toolbar visibility to true.

PW
Comment 21 Paul Webster CLA 2006-04-18 14:55:40 EDT
Created attachment 38832 [details]
Partial visibility patch

Fix up the visiblity of the proxies so that if it's deliberately changed, that information is saved.

PW
Comment 22 Paul Webster CLA 2006-04-19 10:16:03 EDT
Fixed in HEAD >20060419  (Really, this time)

PW
Comment 23 Paul Webster CLA 2006-04-23 10:49:03 EDT
The fix caused bug 137977 on windows.  I've removed the patch for further investigation >20060423.

PW
Comment 24 Paul Webster CLA 2006-04-26 10:40:04 EDT
I'll deal with this post 3.2

PW
Comment 25 Paul Webster CLA 2006-04-28 12:28:06 EDT
*** Bug 138584 has been marked as a duplicate of this bug. ***
Comment 26 Boris Bokowski CLA 2006-05-09 17:27:40 EDT
*** Bug 140937 has been marked as a duplicate of this bug. ***
Comment 27 Boris Bokowski CLA 2006-05-09 17:28:11 EDT
Bug 140937 has reproducible steps.
Comment 28 Missing name Mising name CLA 2006-06-11 14:23:34 EDT
See also bug 105807.  I tend to experience this bug when I have my editor maximised and a view is brought to the top of its (hidden) stack, showing the toolbar where it would be if the editor were not maximised (consistent with comment 10).
Comment 29 Paul Webster CLA 2006-06-15 14:04:47 EDT
*** Bug 147268 has been marked as a duplicate of this bug. ***
Comment 30 Paul Webster CLA 2006-07-10 09:58:39 EDT
*** Bug 150119 has been marked as a duplicate of this bug. ***
Comment 31 Paul Webster CLA 2006-07-17 10:16:49 EDT
*** Bug 150639 has been marked as a duplicate of this bug. ***
Comment 32 Paul Webster CLA 2006-07-21 10:04:25 EDT
*** Bug 151372 has been marked as a duplicate of this bug. ***
Comment 33 Piotr Górny CLA 2006-08-23 03:33:06 EDT
My experience is: toolbar from the console view is shown over the editor area. I have it very often and it's always console view - no matter where do I
hook the view.
Comment 34 Paul Webster CLA 2006-09-28 14:58:19 EDT
*** Bug 128762 has been marked as a duplicate of this bug. ***
Comment 35 Paul Webster CLA 2006-09-28 19:52:21 EDT
*** Bug 134086 has been marked as a duplicate of this bug. ***
Comment 36 Andrey Loskutov CLA 2006-09-30 16:49:09 EDT
Created attachment 51226 [details]
over-complicated test case :)

Hi, I have occasionally reproduced this bug during my performance tests. I have tested with both 3.2.1 and 3.3M2 on WinXP + SDK 1.5.0, in both cases the test fails.

The attached test creates a new perspective with couple of views, and moves the views from right to left and back. One of views is the Console view, which is always invisible, but you could see the console toolbar flying on top of the content of another view :o)

I have attached one of these tests in a standalone test project, which is trimmed first to show the bug on the screen and then fail. Probably one could create more simplified version, because the attached test was not intended as a test for this bug, but as a performance test for presentations.
I hope this helps.
Comment 37 Paul Webster CLA 2006-10-02 07:41:32 EDT
(In reply to comment #36)
> Created an attachment (id=51226) [edit]
> over-complicated test case :)


Thanx, that helps.

PW
Comment 38 Henrik Rentz-Reichert CLA 2006-10-18 09:55:15 EDT
I also observed this behaviour (i.e. the Outline toolbar shown in the top right corner of an open editor).

Steps to reproduce:
- maximize Java editor in Java perspective (Outline in upper right corner)
- switch (still maximized) to an editor with empty outline (e.g. *.ecore or *.properties)
- switch back to Java editor and watch the Outline toolbar appearing...

Eclipse SDK

Version: 3.2.0
Build id: M20060629-1905
Comment 39 Paul Webster CLA 2006-11-10 12:42:11 EST
*** Bug 163669 has been marked as a duplicate of this bug. ***
Comment 40 Timothy Mowlem CLA 2006-11-11 17:17:41 EST
(In reply to comment #39)
> *** Bug 163669 has been marked as a duplicate of this bug. ***
> 

This is really annoying as it is the third version I have seen this in. It has been 'fixed' only to break again in the next 3.x release, so definitely a :-(
Comment 41 Boris Bokowski CLA 2006-11-13 00:04:49 EST
*** Bug 164234 has been marked as a duplicate of this bug. ***
Comment 42 Li Ding CLA 2006-11-30 16:54:53 EST
This problem is very easy to be reproduced when using my graphial editor and other text editor. The problem is that the properties view toolbar shown inside maximized text editor. When this bug will be fixed ? 
Comment 43 Paul Webster CLA 2007-01-30 10:20:34 EST
*** Bug 171564 has been marked as a duplicate of this bug. ***
Comment 44 Dani Megert CLA 2007-01-30 10:45:49 EST
Paul, this is something that we should fix for 3.3.
Comment 45 Dani Megert CLA 2007-02-12 02:25:46 EST
*** Bug 173833 has been marked as a duplicate of this bug. ***
Comment 46 Markus Keller CLA 2007-02-12 06:24:50 EST
(In reply to comment #44)
> Paul, this is something that we should fix for 3.3.

I second that.
Comment 47 Paul Webster CLA 2007-02-12 10:56:22 EST
I'm maxed out with the menu contribution work in 3.3M6.  I hope to get a chance to look at this for RC1, but there's a chance it could slide again.

If someone wants to provide a patch I'll be happy to look at it.

PW
Comment 48 Boris Bokowski CLA 2007-02-13 15:26:10 EST
*** Bug 173974 has been marked as a duplicate of this bug. ***
Comment 49 Mike Wilson CLA 2007-04-05 13:44:05 EDT
Eric, you've been working in this area recently. Can you take a look at this?
Comment 50 Ed Merks CLA 2007-04-05 14:05:23 EDT
Given that the editor doesn't maximize over top of the view as of 3.3 M6 but rather the views are minimized, doesn't that make this problem disappear?  I thought maybe that was part of the motivation.  :-)
Comment 51 Eric Moffatt CLA 2007-04-05 16:30:36 EDT
This is an instance of what Paul and I call the 'floating ToolBar bug' (usually with a few choice words in front). I've been looking at another defect for Markus (bug 122639) in which he gives some repro scenarios...and suspect that these are related. I don't actually see this very much now (including using Markus' steps), I think that Paul's already covered a fair number of the scenarios but have no doubt that there may be others...
Comment 52 Eric Moffatt CLA 2007-04-09 14:12:24 EDT
I've been able to repro this using Markus' steps so I'll mark this as a dup and use the new(er) scenario to test with (most of the scenarios mentioned in this defect no longer occur (at least on my box...;-).


*** This bug has been marked as a duplicate of bug 122639 ***
Comment 53 Genady Beryozkin CLA 2007-06-25 09:20:50 EDT
Created attachment 72352 [details]
Same bug with 3.3RCs

I just got the same bug with the "new" maximized editor.
Build id: I20070608-1718. Worth reopening?
Comment 54 Eric Moffatt CLA 2007-06-25 09:45:13 EDT
Genady, can you give me the repro steps you're using? There are so many flavors of this that I can't tell if this is a new instance or a regression...;-(.

Comment 55 Genady Beryozkin CLA 2007-06-25 10:08:53 EDT
I can't reproduce it and there is nothing in the Error log :(

I can tell that this is the first time I see this bug with the new editor maximization functionality.
I was in the J2EE perspective, working with the "Data Source Explorer" for a while (when it was maximized), then I closed the data source explorer and started working in the Java editor. Then I maximized the editor and got the screenshot you see. The "offending" view is the "Project Explorer".

I use the latest Europa WTP/J2EE plugins.
Comment 56 Paul Webster CLA 2007-06-29 10:54:27 EDT
*** Bug 143919 has been marked as a duplicate of this bug. ***
Comment 57 Martin Aeschlimann CLA 2007-10-04 04:29:17 EDT
*** Bug 205353 has been marked as a duplicate of this bug. ***