Bug 12843 - [CVS UI] "Create Patch" should be in compare menu?
Summary: [CVS UI] "Create Patch" should be in compare menu?
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: PC All
: P3 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-VCM-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
: 16010 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-04-04 19:29 EST by Kevin McGuire CLA
Modified: 2005-01-31 07:22 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2002-04-04 19:29:30 EST
A reasonable use case is:

- external contributor without commit rights does some work
- compares project he's working in against latest/base so he can see which 
resources he's modified
- wishes to produce a patch of these

Essentially, we rely on the user finding the files by hand to patch.  
Supporting it in the compare would be good.  Note syncing with the repo doesn't 
help because:
1. you can't do patch there
2. you can only "Show in Navigator" on single selection (will enter seperate PR 
for that)
Comment 1 James Moody CLA 2002-05-16 14:41:00 EDT
*** Bug 16010 has been marked as a duplicate of this bug. ***
Comment 2 Kevin McGuire CLA 2002-06-11 17:16:50 EDT
later
Comment 3 Michael Valenta CLA 2002-09-09 15:30:32 EDT
Reopening
Comment 4 Robert Klemme CLA 2003-06-04 05:17:00 EDT
I would find it convenient it to also have "Create Patch" in the "CVS Resource 
History View".  But of course it's sufficient to have it in the "Compare View".
Comment 5 Brett Randall CLA 2004-08-18 19:21:25 EDT
I'm voting for this enhancement, wondering if it is on anyone's to-do-soon 
list :-).

Sometimes you can get hold of source code, but not through anonymous CVS 
access.  In those cases, access to diff/create patch through the UI, to create 
a patch from a (self-maintained) pre/post version, would be very useful for 
submitting patches.
Comment 6 Jean-Michel Lemieux CLA 2004-11-09 10:45:53 EST
This is supported in 3.0. You can patch from the synchronize view.
Comment 7 Brett Randall CLA 2004-11-09 16:49:11 EST
Hi Jean-Michel, thanks for your comment.

My support for this enhancement was perhaps based on a slightly different basis 
than the original poster.  I was hoping that patch creation could be achieved 
_without_ the base version being a CVS resource, i.e. allowing two non-version-
controlled resources to be diffed (currently available through Compare), but to 
be able to then go on and create a patch for the diff.
Comment 8 Michal Durdina CLA 2004-12-16 04:43:26 EST
Hello,
I am also voting for 'Create patch' in Synchronize View. Although this 
operation is present in right-click menu for 'Team -> Synchronize with 
Repository...' or 'Compare With -> Latest from HEAD', it does not show up 
for 'Compare With -> Another branch or version'. 

I have a use case for 'Compare With -> Another branch or version'. Two friendly 
companies have their teams working on the common project. Both teams have no 
access to cvs repository of the other team. Each team has its "own" module for 
their part of project in their cvs and import foreign sources for second part 
of project to "foreign" module in their cvs. Each team is commiting changes to 
its own code and send changes to foreign code as patches. Patches are created 
as diff between import tag and patch tag in foreign module.
Comment 9 Michal Durdina CLA 2004-12-16 04:59:52 EST
For the usercase above another alternative would be as follows:

Go to CVS repositories view, in 'Configure Branches and Version...' select and 
add comparing versions (tags), then select both versions in the CVS 
repositories tree and run 'Compare' from right-click menu. Then select 'Create 
patch' in Compare window. Another shorter alternative is not to 
select 'Compare' in the tree menu but select 'Crate patch' tree menu.