Bug 128416 - Open LCD on Targets tab performance regression
Summary: Open LCD on Targets tab performance regression
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on: 136503
Blocks:
  Show dependency tree
 
Reported: 2006-02-17 09:54 EST by Darin Swanson CLA
Modified: 2007-04-26 10:20 EDT (History)
1 user (show)

See Also:


Attachments
CPU Statistics for Eclipse 3.2 M3 run of Ant LCD test (9.01 KB, text/html)
2006-04-12 14:26 EDT, Darin Swanson CLA
no flags Details
CPU Statistics for Eclipse 3.2 N20060411-0010 run of Ant LCD test (10.33 KB, text/html)
2006-04-12 14:27 EDT, Darin Swanson CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2006-02-17 09:54:53 EST
We appear to have a significant decrease in performance for the "Open LCD on Targets tab" test. Inquiring minds want to know why?
Comment 1 Darin Swanson CLA 2006-03-08 11:43:50 EST
Logged bug 130935 for the filtering slowdown in the launch configuration dialog.

I have altered the OpenLaunchConfigurationDialogTests to turn off all of the filtering via the debug preferences.
Comment 2 Darin Swanson CLA 2006-03-28 11:08:38 EST
We have seen improvements with changes to the LCD for filtering etc.
Comment 3 Darin Swanson CLA 2006-03-29 11:41:13 EST
This test opens many many dialogs. We are seeing mininal regression on Linux but major regression on Windows. I hope to do more profiling but it appears to be an issue down below us.
Comment 4 Steve Northover CLA 2006-03-30 18:39:31 EST
Let me know how you get on.
Comment 5 Darin Swanson CLA 2006-04-02 22:10:30 EDT
Tweak released to AntElementNode to have a less expensive hashcode/equals
Comment 6 Steve Northover CLA 2006-04-03 10:34:09 EDT
Is there anything I should be looking into about dialog performance on Windows and Linux?
Comment 7 Darin Swanson CLA 2006-04-12 11:52:23 EDT
I am going to spend time on this today so I can be more helpful in pinning down what is causing the differences.
Comment 8 Darin Swanson CLA 2006-04-12 14:26:23 EDT
Created attachment 38433 [details]
CPU Statistics for Eclipse 3.2 M3 run of Ant LCD test
Comment 9 Darin Swanson CLA 2006-04-12 14:27:14 EDT
Created attachment 38434 [details]
CPU Statistics for Eclipse 3.2 N20060411-0010 run of Ant LCD test
Comment 10 Darin Swanson CLA 2006-04-12 14:28:39 EDT
The major diff that jumps out at me is the change in org.eclipse.swt.internal.win32.OS.CallWindowProcW(int, int, int, int, int)

This is on WinXP on Sun JDK 1.4.2_08
Comment 11 Steve Northover CLA 2006-04-12 18:11:41 EDT
CallWindowProcW() is just calling the window proc for whatever the particular control is and asking windows to process a WM_ style message for a control.  The interesting this is that it should be getting called about the same number of times if the same controls exist in the test for M3 and N20060411-0010.

What does the dialog look like?  Is the code UI code the same?  Have label controls been replaced by text controls?  Can you attach a picture of the dialog?
Comment 12 Darin Swanson CLA 2006-04-12 18:24:10 EDT
Ok...I will get method call information and more info on who is doing the calling.

The dialog (the debug launch configuration dialog) has changed to include a toolbar that used to just be some buttons for creation, duplication, removal etc of launch configurations. I will check on how this change maps to when the regressions showed up...I do not believe it is a direct match.

Is it at all interesting that almost no regression on Linux but large on WinXP?
Are there some controls that are just known to be worse on WinXP than Linux?
Comment 13 Steve Northover CLA 2006-04-13 11:57:27 EDT
>Is it at all interesting that almost no regression on Linux but
>large on WinXP?

Yes.  Although many people claim that Windows is faster, really some things are faster on Windows, some on GTK.

>Are there some controls that are just known to be worse on WinXP
than Linux?

Not really.  The bug system contains some information like this but the versions of the operating systems change and the underlying technology changes so fast that there are no generalizations.  For example, new version of GTK use cairo under the covers to render the widgets.

I am very interested in your findings.  Please keep up the good work.  It's a pitty that we aren't in the same location or I'd be hot to hack this with you.
Comment 14 Darin Swanson CLA 2006-04-13 14:34:43 EDT
Hopefully this will be my Friday fun project :-)
Comment 15 Steve Northover CLA 2006-04-17 13:21:49 EDT
Anything?
Comment 16 Darin Swanson CLA 2006-04-17 13:28:47 EDT
Apologizing again...I am currently swamped with the Jazz work.
Comment 17 Darin Swanson CLA 2006-04-27 10:35:32 EDT
Nothing more planned for 3.2 RC2
Comment 18 Darin Swanson CLA 2006-05-10 00:23:11 EDT
Opportunity for improvement in 3.3
Comment 19 Darin Swanson CLA 2007-04-26 10:20:22 EDT
Decision has been made to remove these performance tests.

With the changes to the launch configuration framework (new features added) these tests were no longer representative of changes / regressions in the Ant integration.