Bug 127137 - [Workbench] Installing new feature from update site resets workbench layout
Summary: [Workbench] Installing new feature from update site resets workbench layout
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux-GTK
: P3 critical with 2 votes (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Branko Tripkovic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 79615 140277 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-02-09 14:27 EST by Jared Burns CLA
Modified: 2006-05-05 14:43 EDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2006-02-09 14:27:47 EST
Build 20060208

After installing a new feature from a local update site, I was prompted to restart the workbench and accepted. When the workbench restarted, my perspective layout was reset.

When Update restarts the workbench, does it prevent the layout settings from being stored?
Comment 1 Branko Tripkovic CLA 2006-02-20 00:42:39 EST
This should not happen what plug-in did you update?
Comment 2 Jared Burns CLA 2006-02-20 12:54:36 EST
A proprietary plug-in which contributes a couple of simple menu items. The plug-ins I installed certainly don't touch the perspective layout.
Comment 3 Willian Mitsuda CLA 2006-02-24 14:15:52 EST
I can confirm this bug on Eclipse 3.2 M5.

Steps to reproduce:

- Make a clean installation
- Open Eclipse, and modify the workbench layout (add, remove, move, resize view, etc.)
- Restart Eclipse.
- The layout remains the same.
- Go to Install -> Update -> Search for new features to install.
- Add a update site, eg: Subclipse Update Site (http://subclipse.tigris.org/update).
- Install some feature.
- Eclipse asks to restart, yes.
- The workbench layout is reset.

This is a very annoying bug, since I'm moving to 3.2, but every time I decide to install a new plugin it resets all my layout customizations...
Comment 4 Pascal Rapicault CLA 2006-03-03 12:46:00 EST
I can reproduce with the steps from comment #3.
Moving this bug to the UI team and marking as critical for Callisto.
Comment 5 Eric Moffatt CLA 2006-03-06 10:05:43 EST
Mvm, as discussed this may be related to bug 79615.
Comment 6 Gabriele Garuglieri CLA 2006-03-29 01:53:53 EST
I experimented a bit yesterday with Callisto and this bug makes the site practically unusable.
We are stuck to manual update because our developers cannot afford loosing all their customizations just because they tried to update a plugin.
Comment 7 Willian Mitsuda CLA 2006-03-29 10:43:28 EST
Too bad this won't be addressed in M6.

Any chance to raise the priority to P1 for RC1?
Comment 8 Jared Burns CLA 2006-03-29 13:02:36 EST
In my opinion, this is a blocking defect for the 3.2 release. We shouldn't ship with such a major flaw in Update.
Comment 9 Stefan Langer CLA 2006-04-11 05:42:49 EDT
I can confirm this on Windows XP Pro install using Eclipse3.2M6 on JSE1.5.0_06 from SUN.
Plugins I installed which caused this behaviour are 
SpringIDE
Mylar0.4.10 as well as 0.5.0
Subclipse
Subversive


Comment 10 Stefan Langer CLA 2006-04-18 12:11:54 EDT
Just checked Eclipse3.2RC1 and the defect is still there. The offensive plugin this time is Mylar 0.5.0.

Steps to reproduce:
Install fresh copy of Eclipse3.2 RC1 
Grab Mylar from the update site and install it 
Restart upon request and the workbench layout will be reset upon next start. 

Not sure if it is important but I'm installing my plugins to separate install locations. 
Comment 11 Michael Van Meekeren CLA 2006-04-19 17:22:22 EDT
I found the problem here.  Update is calling Workbench.restart() twice.   After the first call all windows are closed etc... so saving state the second time saves essentially an empty file.  Here is the patch to update please apply this.  I have logged another bug for Workbench to be more proactive in warning that the state is being saved a second time.  see bug 137610


### Eclipse Workspace Patch 1.0
#P org.eclipse.update.ui
Index: src/org/eclipse/update/internal/ui/wizards/InstallWizard2.java
===================================================================
RCS file: /home/eclipse/org.eclipse.update.ui/src/org/eclipse/update/internal/ui/wizards/InstallWizard2.java,v
retrieving revision 1.10
diff -u -r1.10 InstallWizard2.java
--- src/org/eclipse/update/internal/ui/wizards/InstallWizard2.java	10 Apr 2006 21:48:58 -0000	1.10
+++ src/org/eclipse/update/internal/ui/wizards/InstallWizard2.java	19 Apr 2006 21:02:02 -0000
@@ -469,7 +469,6 @@
                 
                 Job installJob = new Job(UpdateUIMessages.InstallWizard_jobName) { 
         			public IStatus run(IProgressMonitor monitor) {
-        				install(monitor);
         				if (install(monitor)) {
         					return Status.OK_STATUS;
         			} else {


Comment 12 Michael Van Meekeren CLA 2006-04-19 17:23:10 EDT
Dejan, could you please get this patch in for 3.2 RC2?
Comment 13 Dejan Glozic CLA 2006-04-19 17:33:07 EDT
Branko, can you handle this? Seems bad that we are calling restart twice.
Comment 14 Michael Van Meekeren CLA 2006-04-20 11:51:30 EDT
*** Bug 79615 has been marked as a duplicate of this bug. ***
Comment 15 Branko Tripkovic CLA 2006-04-24 15:05:36 EDT
applied
Comment 16 Mik Kersten CLA 2006-05-05 14:43:13 EDT
*** Bug 140277 has been marked as a duplicate of this bug. ***