Bug 12642 - Search dialog opens slowly when java file is selected
Summary: Search dialog opens slowly when java file is selected
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-04-02 14:01 EST by Tod Creasey CLA
Modified: 2002-05-30 01:42 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2002-04-02 14:01:28 EST
If you are in the Java Perspective with class 
org.eclipse.jdt.internal.compiler.parser.Parser selected when you hit Ctrl H it 
can take several seconds to open (as long as 6 seconds).

There should be a busy cursor for opening this dialog. As well when I benched 
the opening of the dialog with the OptimizeIt profiler I found that 
initializing the selection (JavaSearchPage.initSelections() took 52.8% of the 
time to open the dialog.
Comment 1 Dani Megert CLA 2002-04-17 04:20:47 EDT
Did you dig into the method? I don't think JavaSearchPage.initSelections() 
took the time but the JavaModel to do the code resolve. ==> it depends on what's
selected. Could you provide the selection because when I tried it it was fast.
Maybe there's a bug in the Java Model for the type/code you selected.


Comment 2 Erich Gamma CLA 2002-05-12 06:50:29 EDT
It was fast when tired it as well.

One difference between Tod's and Dani's workspace could be that Tod has a full 
source workspace. 

I also suspect that code resolve is expensive. Showing a busy cursor when 
bringing up this dialog is fair.
Comment 3 Erich Gamma CLA 2002-05-24 20:42:47 EDT
Dani did you try this scenario in the full source workspace?
Comment 4 Dani Megert CLA 2002-05-30 01:42:56 EDT
I tested this in the full workspace scenario (i.e. whole Eclipse as source)
against build F1.

- Test 1: Start workspace drilled into the package and selected CU, Ctrl+H
- Test 2: Start workspace drilled into the package and selected type Parser, Ctrl+H
- Test 3: Start workspace opened type Parser and selected Parser, Ctrl+H

All tests opened the Java Search page immediately with the right values filled in.

Maybe there was a problem in earlier builds or the Lotus Notes was using most of
the CPU (that sometimes happens to me).