Bug 126195 - [WorkbenchParts] WorkbenchPartReference and ISaveableModelSource
Summary: [WorkbenchParts] WorkbenchPartReference and ISaveableModelSource
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2006-02-02 10:28 EST by Michael Valenta CLA
Modified: 2006-02-09 22:31 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2006-02-02 10:28:28 EST
Should WorkbenchPartReference make use of IsaveableModelSource. It seems that it should so that handling of dirty determination for a part will be consistent. That is, the Save action ignores the isDirty of the part when issuing saves whereas the reference makes use of it. Perhaps this is intentional to separate the dirty decoration of a part tab (in my case, an editor) from the save behavior. If that is so, it needs to be well documented.
Comment 1 Nick Edgar CLA 2006-02-03 10:12:32 EST
For now, I'm intentionally leaving it up to the part to communicate its own dirty state, taking into account the models it presents if needed.
There may be cases where a view wants to work in terms of models, but not show a dirty flag even if the models are dirty.
Comment 2 Nick Edgar CLA 2006-02-09 22:31:49 EST
No plans to change this for 3.2.