Bug 125985 - [PresentationAPI] Show icons for inactive views in certain folders
Summary: [PresentationAPI] Show icons for inactive views in certain folders
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P5 enhancement (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2006-02-01 03:01 EST by Thomas Schindl CLA
Modified: 2014-05-02 04:47 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2006-02-01 03:01:18 EST
I'm uncertain because may this is already possible and I simply haven't found it.

It would be nice if one can set some flag when creating the ITableFolderLayout to always display the Tab-Image. Actually it is vanishing if another View is focused.
Comment 1 Kim Horne CLA 2006-02-07 11:40:44 EST
Can you tell me what package ITableFolderLayout is in?  I can't find it in our source or via a Google search.
Comment 2 Thomas Schindl CLA 2006-02-07 12:48:27 EST
pas de problem ;-)
The Interface can be found: 
 - org.eclipse.ui.IFolderLayout

The Class implementing this Interface: 
 - org.eclipse.ui.internal.FolderLayout

The responsible to to show icons on focus lost time is: 
 - org.eclipse.ui.presentations.WorkbenchPresentationFactory
   The code in question is:
   ----------------8<----------------------
   public StackPresentation createViewPresentation(Composite parent,
            IStackPresentationSite site) {
       // ...
       folder.setUnselectedImageVisible(false);
       // ...
   }

My idea is to add the following methods to IFolderLayout:
 - public void setUnselectedImageVisible(boolean unselectedImageVisible);
 - public boolean getUnselectedImageVisible();

And the it could be used like at the moment e.g.: setCloseable(), setMoveable()
Comment 3 Thomas Schindl CLA 2006-02-07 12:55:38 EST
(In reply to comment #1)
> Can you tell me what package ITableFolderLayout is in?  I can't find it in our
> source or via a Google search.
> 

sorry should be FolderLayout, corrected the title
Comment 4 Nick Edgar CLA 2006-02-07 13:38:10 EST
It's currently the active presentation (org.eclipse.ui.presentations extension point) that gets to decide whether to show icons for inactive views or not.

Are you requesting an overall change to the application look and feel, or do you really want per-folder control over this?

The former could be addressed by using a different presentation, or adding a preference to the default presentation to show icons for inactive views.
Comment 5 Thomas Schindl CLA 2006-02-08 02:49:40 EST
I didn't know that this is possible how can I control with presentation is selected? I've started learning RCP by taking a look at the Mail-Example. How can I change the presentation to have one showing inactive icons.

Nevertheless I think it would be nice to control whether icons should be shown when the tab is inactive would be a nice feature. At the moment you can also control whether e.g. the title is shown or not and you have not to change the presentation.
Comment 6 Nick Edgar CLA 2006-02-08 09:27:46 EST
For more on the presentations mechanism, see:
http://wiki.eclipse.org/index.php/RCP_FAQ#presentations
Comment 7 Paul Webster CLA 2006-09-28 11:01:34 EDT
There are currently no plans to work on this feature.

PW
Comment 8 Denis Roy CLA 2007-06-22 09:33:18 EDT
Changes requested on bug 193523
Comment 9 Lars Vogel CLA 2014-05-02 04:47:45 EDT
The PresentationAPI has been deprecated with the Eclipse 4.x release and it has been replaced with the CSS engine. I therefore close this bugs as WONTFIX. In case your bug report is still valid for the Eclipse 4.4 release, please open a new bug report for it.