Bug 125805 - [Wizards] Additional filtering criteria for CVS commits
Summary: [Wizards] Additional filtering criteria for CVS commits
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 12580 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-01-31 05:35 EST by Paul Loveridge CLA
Modified: 2019-09-06 16:17 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Loveridge CLA 2006-01-31 05:35:55 EST
Could we have a facility for preventing CVS commits to resources with errors or warnings.

Such a facility should ideally be controllable from the Team\CVS preferences tree and consist of two checkboxes -

[ ] Allow commit of resources with warnings
[ ] Allow commit of resources with errors.

By default both of these options should be switched on, in which case the CVS system performs as it currently does. 

Switching off either of these two checkboxes results in the appropriate files not appearing in the CVS window in the outgoing mode view.
Comment 1 Michael Valenta CLA 2006-01-31 08:29:16 EST
I think this would be useful but I think the default shoudl be for errors to be on and warnings to be off by default. If a team doesn't want a particular type of warning committed, they can just switch the Java (or other tool) preference for that problem to be an error. Also, I think it is dangerous to exclude elements with errors. Either we abort the operation or prompt the user to adsk them if they are sure they want to commit the errors (i.e. if I am working on a branch, I may decide that committing errors is OK). We could probably offer options similar for what we do for empty commit comments.
Comment 2 Paul Loveridge CLA 2006-01-31 08:32:56 EST
The reason I requested this feature for warnings as well as errors is that my current boss has a policy of not committing anything with warnings.

Could we have a three options for both warnings and errors ?
1. Commit 
2. Confirm commit
3. Never commit.

And set it to 1 by default (which would leave default behaviour as it is now) ?
Comment 3 Michael Valenta CLA 2006-01-31 08:46:57 EST
That makes sense. The options could be 1 for both of them and teams could tailor them as they see fit.
Comment 4 Michael Valenta CLA 2006-02-22 16:59:27 EST
We won't have time to address this in 3.2
Comment 5 Michael Valenta CLA 2006-06-16 10:50:57 EDT
*** Bug 12580 has been marked as a duplicate of this bug. ***
Comment 6 Michael Valenta CLA 2006-06-16 10:51:53 EDT
We should also consider prompting if there are other projects in the workspace with errors since the errors may be caused by what is being committed.
Comment 7 Michael Valenta CLA 2006-09-14 11:05:06 EDT
We do not plan on addressing this issue in 3.3.
Comment 8 Eclipse Webmaster CLA 2019-09-06 16:17:29 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.