Bug 124849 - Reduce use of System.out throughout the code.
Summary: Reduce use of System.out throughout the code.
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-23 08:01 EST by Maxime Daniel CLA
Modified: 2015-11-23 14:47 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2006-01-23 08:01:43 EST
Fup on bug 99620. There are many other uses of System.out than those suppressed when fixing bug 99620. I would suggest that we lower their number significantly.
This is not trivial since:
- quite a few of them are expected to remain in the source code (for example, some constructors with a simplified signature call more complete ones with System.out and System.err as parameters - in such case, System.out and System.err provide reasonable defaults to the more complete constructor);
- the caller may not always have a natural replacement for it; in such cases, driving the appropriate parameters (and fields) into the code calls for more thinking.
Comment 1 Olivier Thomann CLA 2006-10-10 15:52:22 EDT
Maxime,

I believe this can be closed.
Comment 2 Maxime Daniel CLA 2006-11-28 12:11:34 EST
There are 1164 references to System.out and 34 references to System.err in org.eclipse.jdt.core. I would consider that a good starting point would be to rationalize the tracing capabilities and to use explicit loggers for the parts of the source that may leverage 1.4, to home made loggers for the other parts (this is partly the case, but System.err still shows up in calls to Util.verbose). But I agree that this is a judgement call.
The question must be something like: do we reduce the use of System.out and System.err to very few places that match precise criteria, or else do we consider that their use throughout the code is fine?
Note: the use of explicit loggers in code conditionned by debug flags should be no big issue performance wise. We may want to avoid that elsewhere.
Will move this to Philippe for decision.
Comment 3 Olivier Thomann CLA 2011-05-31 11:25:51 EDT
There is no usage besides the one in DEBUG mode.
Will close post 3.7.