Bug 99620 - [compiler] The batch compiler should not print to the console when taking another output stream in input
Summary: [compiler] The batch compiler should not print to the console when taking ano...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 minor (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Maxime Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-13 08:49 EDT by Maxime Daniel CLA
Modified: 2006-02-14 08:43 EST (History)
0 users

See Also:

Attachments
Suggested change plus tests (52.16 KB, patch)
2006-01-19 04:49 EST, Maxime Daniel CLA 		no flags Details | Diff
Improved patch plus tests (58.19 KB, patch)
2006-01-23 07:56 EST, Maxime Daniel CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2005-06-13 08:49:12 EDT 
This is a follow up on https://bugs.eclipse.org/bugs/show_bug.cgi?id=98489,
which only bypassed the impacted test cases. Please see details there.
Not urgent.
Comment 1 Maxime Daniel CLA 2006-01-19 04:49:32 EST 
Created attachment 33254 [details]
Suggested change plus tests

Olivier, pls tell me what you think.
Comment 2 Olivier Thomann CLA 2006-01-19 11:32:38 EST 
Patch looks good.
We migth want to factorize the code for Compiler constructors.
Make out field protected and update the call in org.eclipse.jdt.core.dom.CompilationUnitResolver line 171.

Also we should consider making the same support for err.
Comment 3 Maxime Daniel CLA 2006-01-23 07:56:14 EST 
Created attachment 33456 [details]
Improved patch plus tests
Comment 4 Maxime Daniel CLA 2006-01-24 04:17:38 EST 
Test case: launch BatchCompilerTest and watch the console.
Comment 5 Jerome Lanneluc CLA 2006-02-14 08:43:26 EST 
Verified for 3.2 M5 using build I20060214-0010