Bug 123430 - Patch file misses changes without network connection during patch creation without indication
Summary: Patch file misses changes without network connection during patch creation wi...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3 M6   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-01-11 09:57 EST by Philip Mayer CLA
Modified: 2007-03-21 09:09 EDT (History)
1 user (show)

See Also:

Attachments
Fix (2.56 KB, patch)
2007-02-28 08:02 EST, Krzysztof Daniel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Mayer CLA 2006-01-11 09:57:15 EST 
I20060110-1026

Have some workspace with a project under CVS on a remote server (pserver connection) and 
1) changes to already existing files and 
2) some new files as well. 

Disconnect your machine from the network. Now invoke "Create Patch..." on this project. Verify all changes (both in existing files and new files) are in the preview. Press Finish. 

The patch creation finishes and there is no indication that anything went wrong. A patch file is created, but the file contains only the new files and none of the changed files.

As it looks like the patch was created with all changes, this may lead to data loss if the user removes his changes from the workspace, only relying on the created patch.
Comment 1 Krzysztof Daniel CLA 2007-02-28 08:02:17 EST 
Created attachment 59968 [details]
Fix

This bug was caused because all errors returned by the DIFF operation are ignored, because the DIFF operation always returns error when file differs.
Comment 2 Michael Valenta CLA 2007-02-28 10:16:26 EST 
Patch released to HEAD.
Comment 3 Michael Valenta CLA 2007-03-20 13:41:43 EDT 
Patch missed a required syncExec when opening an error dialog
Comment 4 Michael Valenta CLA 2007-03-21 09:09:23 EDT 
I've added the require sync exec