Bug 122422 - Making ECrossReferenceEList overrides simpler
Summary: Making ECrossReferenceEList overrides simpler
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Core (show other bugs)
Version: 2.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Marcelo Paternostro CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-12-31 09:01 EST by Didier Villevalois CLA
Modified: 2008-05-13 17:09 EDT (History)
1 user (show)

See Also:

Attachments
Patch for ECrossReferenceEList implementation (1.75 KB, patch)
2005-12-31 09:03 EST, Didier Villevalois CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Didier Villevalois CLA 2005-12-31 09:01:16 EST 
In case you want to override ECrossReferenceEList to override isIncluded(), you also have to override its two Iterators (static inner classes) to also overide their isIncluded(). However, it is not clear what ECrossReferenceEList's method you have to overide to return those iterators instance. Choices are:

basicIterator()
basicListIterator()
basicListIterator(int)
newListIterator()

all of which are implemented independently!

It would be nice that all those are implemented based on a newListIterator(boolean resolve) method.
Comment 1 Didier Villevalois CLA 2005-12-31 09:03:07 EST 
Created attachment 32380 [details]
Patch for ECrossReferenceEList implementation

I've added a patch to implement this new protected method and change the implementation of the other methods to be based on it.
Comment 2 Ed Merks CLA 2006-01-23 11:32:14 EST 
I made changes analagous to this, but up in EContentsEList.
Comment 3 Nick Boldt CLA 2006-01-26 02:05:36 EST 
Fixed in 2.2.0 I200601260027
Comment 4 Dave Steinberg CLA 2006-02-10 14:52:11 EST 
[contrib email="ptitjes@beuz.org"/]
Comment 5 Nick Boldt CLA 2008-01-28 16:46:08 EST 
Move to verified as per bug 206558.