Bug 121433 - [Operations] After "switch to branch", new and deleted files were checked into previous branch
Summary: [Operations] After "switch to branch", new and deleted files were checked int...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows XP
: P5 major with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
: 80514 289913 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-12-19 11:38 EST by Adam Hupp CLA
Modified: 2019-11-14 03:53 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Hupp CLA 2005-12-19 11:38:49 EST
I have 3 branches, A, B, and C.  I have merged changes from branch B into my workspace that is on branch A.  I then created branch C off of A and did Team->Switch to Another Branch or Version in my workspace so that I could check the merge into C.  After the commit, I found that all new and deleted files from the merge appeared on branch A, while the changed files correctly appeared on C.
Comment 1 Michael Valenta CLA 2006-06-19 15:40:25 EDT
*** Bug 80514 has been marked as a duplicate of this bug. ***
Comment 2 Pawan Singh CLA 2009-07-13 16:16:26 EDT
When will this get fixed? It has been open for years!!!
Comment 3 Mauro Molinari CLA 2009-09-04 05:03:33 EDT
The severity of this bug should be incremented, because it's very easy to corrupt branches and then it's hard to rollback.

Suppose you're working on branch A and you do some work (change some files, remove some others), then you realize that those changes don't have to be committed on branch A, but rather on branch B. So, you issue a "Switch to branch" and select B. Now, if you commit your changes, this is the result:
- changed files are committed to B
- deleted files are committed to A!!!

So, not only you don't commit removals to B, but you even remove files in A, which could lead to a disaster, also because you can't notice it, unless you work with the same repository using another client or another Eclipse instance!

This is very annoying and serious bug, IMHO, and I can't understand how it can be still open since December 2005 (although I understood that there have been no will to invest in Eclipse CVS support anymore for a long time...).
Comment 4 Tomasz Zarna CLA 2009-11-20 07:49:44 EST
*** Bug 289913 has been marked as a duplicate of this bug. ***
Comment 5 Tomasz Zarna CLA 2009-11-20 07:52:11 EST
Bug 289913 describes another scenario that ends up with unexpected state.
Comment 6 Mauro Molinari CLA 2009-11-20 08:11:46 EST
(In reply to comment #5)
> Bug 289913 describes another scenario that ends up with unexpected state.

It's the exactly same situation decribed in my comment #3.

This bug has been here for four years now and it's actually a major issue... :-(
Comment 7 Pawel Pogorzelski CLA 2009-11-20 10:23:04 EST
Bumping the severity based on duplicate bug 289913.
Comment 8 Mauro Molinari CLA 2010-06-25 12:14:51 EDT
Is there any plan to work on this serious bug?

It is even worst because I just verified in Eclipse 3.5 that if the OLD tag (the one you switched from) is a TAG (and not a branch), if you commit a deleted file the file is actually DELETED from the TAG (that is, the tag is removed from the file!).

In other words: Eclipse not only deletes the file from the wrong place, but it even does it if the wrong place is a tag (and not a branch), while I think everyone would expect a tag to be read-only, unless explicitly removed!
Comment 9 Mauro Molinari CLA 2011-10-17 08:18:57 EDT
Any news on this? Could this be targeted for 3.8?
Comment 10 Tomasz Zarna CLA 2011-10-18 04:31:54 EDT
I agree this should be fixed but unfortunately, right now we don't have the manpower to address it. Please note this bug is tagged with "helpwanted", patches will be accepted.
Comment 11 Lars Vogel CLA 2019-11-14 03:34:46 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.
Comment 12 Mauro Molinari CLA 2019-11-14 03:53:55 EST
Hi Lars,
I think this bug should make you think about what you want to do with the CVS client. This is a severe bug which I really doubt it was fixed. I don't have CVS any more so I can't test, but here the main question is: does any committer/maintainer want to still support CVS in Eclipse or not?
If the answer is yes, I don't think that marking all CVS bugs as "stalebug" will bring any value, since it's normal that they didn't have any activity during the latest years...
If the answer is no, then IMHO marking all CVS bugs as "stalebug" isn't useful either, just deprecate the CVS plugin and bulk close all bugs as "WONTFIX" or "deprecated" or something like that...

Just my 2 cents... (also spoiled by the fact that I personally don't like these kind of "stalebug" activities ;-)