Bug 121313 - PDE outline broken in 3.2 M4
Summary: PDE outline broken in 3.2 M4
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.4   Edit
Hardware: All All
: P1 minor (vote)
Target Milestone: ---   Edit
Assignee: Brock Janiczak CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-17 03:10 EST by Brock Janiczak CLA
Modified: 2005-12-18 19:09 EST (History)
0 users

See Also:

Attachments
Patch to PdeUiBridge (1.24 KB, patch)
2005-12-17 03:12 EST, Brock Janiczak CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brock Janiczak CLA 2005-12-17 03:10:29 EST 
Another field was renamed after the last round of fixes.  treeViewer is not fTreeViewer.  If you try to apply mylar to the PDE outline you will get a curious error in your log:
treeViewer, source: org.eclipse.mylar.xml.pde.PdeUiBridge
Comment 1 Brock Janiczak CLA 2005-12-17 03:12:40 EST 
Created attachment 31899 [details]
Patch to PdeUiBridge

getContentOutlineViewers will now look for a field called fTreeViewer as well as treeViewer.
Comment 2 Mik Kersten CLA 2005-12-18 18:24:07 EST 
Patch applied, thanks Brock!  Since we don't yet have PDE UI test fixtures like we do for Java, I improved the error handling around PDE failures in Mylar UI.  But in the next couple of releases I would like to improve the PDE support and make some API requests, and will create those test facilities.
Comment 3 Mik Kersten CLA 2005-12-18 19:08:33 EST 
Reassigning to Brock whose patch resolve this.
Comment 4 Mik Kersten CLA 2005-12-18 19:09:44 EST 
Resolved, fix will be in 0.4.6.1 build for Eclipse 3.2 put out today or tomorrow.