Bug 120915 - [Help] Clicking on search result group shows XML document
Summary: [Help] Clicking on search result group shows XML document
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-12-14 12:39 EST by Curtis d'Entremont CLA
Modified: 2007-06-11 11:02 EDT (History)
0 users

See Also:


Attachments
Tests for hrefs with ".xml" extensions and omits them (1.05 KB, text/plain)
2007-02-20 10:14 EST, Adam Archer CLA
no flags Details
Forgot to mark the above attachment as a patch (1.05 KB, patch)
2007-02-20 10:15 EST, Adam Archer CLA
no flags Details | Diff
Option #2 from above implemented (3.74 KB, patch)
2007-02-21 15:54 EST, Adam Archer CLA
no flags Details | Diff
fixed (3.79 KB, patch)
2007-02-21 17:56 EST, Adam Archer CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis d'Entremont CLA 2005-12-14 12:39:11 EST
I20051214-0800

- Go to Help -> Search
- Search for "test"
- Enable Show Result Categories toolbar toggle button
- Scroll down to the Java Development User Guide section
- Click on it
- Bug: I see XML markup for the table of contents for this topic

It works if I right click and open in Help Contents
Comment 1 Adam Archer CLA 2007-02-20 10:14:27 EST
Created attachment 59377 [details]
Tests for hrefs with ".xml" extensions and omits them

If the href for a category has a ".xml" extension, a link will not be created. The heading will just be text (same behaviour as if the href was null). In future, we may want to modify this further so that one of two things happens:

1) The category heading links to the auto generated topics that are presented in the help window when no document exists (i.e. a menu of subtopics). This behaviour might be odd since there is no other way to find these documents in the help view.

OR

2) The category heading switches the help view to display the help contents with the appropriate category expanded.
Comment 2 Adam Archer CLA 2007-02-20 10:15:32 EST
Created attachment 59378 [details]
Forgot to mark the above attachment as a patch

Same attachment as above.
Comment 3 Curtis d'Entremont CLA 2007-02-20 11:07:47 EST
I vote #2. Could you post a new patch with this addition?
Comment 4 Adam Archer CLA 2007-02-21 15:54:39 EST
Created attachment 59515 [details]
Option #2 from above implemented

The category links will now switch the help view to the All Topics page and expand the selected topic. They will also set the selection in the treeviewer to the selected topic.
Comment 5 Adam Archer CLA 2007-02-21 17:30:53 EST
I just noticed a bug with the fix. If the topic is already open on the All Topics page, it will be collapsed by clicking the link. I will correct this and submit a new patch.
Comment 6 Adam Archer CLA 2007-02-21 17:56:57 EST
Created attachment 59524 [details]
fixed
Comment 7 Curtis d'Entremont CLA 2007-02-21 19:33:42 EST
Patch applied.
Comment 8 Adam Archer CLA 2007-06-11 11:02:59 EDT
Verified in I20070608-1718.