Community
Participate
Working Groups
Reporter: Jiang Lin Quan JRE Version: SUN JRE 1.4.2_07 Browser: IE 6 OS: windows XP professional Eclipse version:3.1.0 <<Steps To Reproduce>> 1, Launch the Help. 2, Use the keyboard is able to expand the top-level items in the navigation tree(the Book icons) using the right and left arrows. <<Actual Result>> When the user clicks the Right arrow to expand it, it expands and focus is kept on the heading with the Book icon. But if the user then closes the Book by using the left arrow, the focus jumps to the frame (top) of the navigation tree frame instead of remaining on the heading for the Book icon. <<Expected Result>> When the user clicks the Right arrow to expand it, it expands and focus is kept on the heading with the Book icon. When the user then closes the Book by using the left arrow, the focus remains on the heading for the Book icon. <<Cause>> There are no code to deal with book collapse. <<Solution>> Add the code to deal with book collapse in toc.js and tocview.jsp
Created attachment 32308 [details] Patch for this bug
Created attachment 32317 [details] Patch for this bug For book level operation, This patch add: 1, use left key collapse the book function. 2, single click the book icon expand/collapse function. 3, double click the book link expand/collapse function.
I like the functionality you added with the patch, particularly the single click on the book icon to expand. However sometimes this part doesn't work for me. For example, if I click on the link to expand, I can click on the book icon to collapse, but if I click on another book icon to expand, it won't work. Any ideas?
Hi, you could add following patch to fix what you said. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -202,7 +202,7 @@ } else { %> <li> - <img src="<%=prefs.getImagesDirectory()%>/toc_closed.gif" alt="<%=ServletResources.getString("bookClosed", request)%>" title="<%=ServletResources.getString("bookClosed", request)%>"><a id="b<%=toc%>" name="<%=data.getTocHref(toc)%>" style="font-weight: bold;" href="<%=data.getTocDescriptionTopic(toc)%>" onclick='loadTOC("<%=data.getTocHref(toc)%>")'><%=data.getTocLabel(toc)%></a> + <img src="<%=prefs.getImagesDirectory()%>/toc_closed.gif" onclick='loadTOC("<%=data.getTocHref(toc)%>")' alt="<%=ServletResources.getString("bookClosed", request)%>" title="<%=ServletResources.getString("bookClosed", request)%>"><a id="b<%=toc%>" name="<%=data.getTocHref(toc)%>" style="font-weight: bold;" href="<%=data.getTocDescriptionTopic(toc)%>" onclick='loadTOC("<%=data.getTocHref(toc)%>")'><%=data.getTocLabel(toc)%></a> <% } %> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thanks Jiang, that did the trick. Patch applied.
