Bug 120602 - [History View] Should have an Open With
Summary: [History View] Should have an Open With
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2005-12-13 11:31 EST by Michael Valenta CLA
Modified: 2009-11-12 08:56 EST (History)
7 users (show)

See Also:

Attachments
Fix v01 (24.58 KB, patch)
2008-12-04 05:45 EST, Szymon Brandys CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2005-12-13 11:31:22 EST 
It would be nice if we had an Open With menu item in the view that allowed the user to decide which editor to use (e.g. Java or Text). We would need support form IDE for this to provide us with the set of editors that were remote-aware.
Comment 1 Markus Keller CLA 2006-02-17 04:46:54 EST 
Sounds like the same problem as bug 37255 and bug 100623.
Comment 2 Michael Valenta CLA 2006-12-11 11:33:16 EST 
We do not have the manpower to address this in 3.3.
Comment 3 Michael Valenta CLA 2007-06-19 15:08:34 EDT 
*** Bug 100623 has been marked as a duplicate of this bug. ***
Comment 4 Michael Valenta CLA 2007-06-19 15:09:27 EDT 
With such an API, we could also add Open With to the CVS Repo View
Comment 5 Remy Suen CLA 2007-09-23 07:57:13 EDT 
(In reply to comment #0)
> We would need support
> form IDE for this to provide us with the set of editors that were remote-aware.

I'm not sure how they would go about providing this as people can arbitrarily contribute editors to the platform.
Comment 6 Szymon Brandys CLA 2008-12-04 05:45:39 EST 
Created attachment 119486 [details]
Fix v01
Comment 7 Szymon Brandys CLA 2008-12-04 06:41:49 EST 
The fix adds the "Open With..." menu to the history view context menu. The next step would be to add the menu to the Repo view. I'm reopening bug 100623 which is not a dupe of this issue.

The UI support mentioned in the comment 0 is a nice-to-have thing, however the "Open With.." menu can work without it.

The fix is released to HEAD.
Comment 8 Markus Keller CLA 2008-12-04 10:33:40 EST 
> The UI support mentioned in the comment 0 is a nice-to-have thing, however the
> "Open With.." menu can work without it.

I saw you copied OpenWithMenu from org.eclipse.ui.ide and opened bug 257515 for the missing API from ui.workbench.

Couldn't you avoid copying OpenWithMenu and instead open up the original class a bit? I think opening editors on non-file inputs would also be interesting for other clients, so it would better live in ui.workbench.
Comment 9 Markus Keller CLA 2008-12-04 10:44:35 EST 
Moreover, can this ever work with external (system) editors? I guess not, unless you create a copy of the file in the file system (as requested in bug 37255). You should at least disable external editors and also not offer them in the Others... dialog.
Comment 10 Szymon Brandys CLA 2008-12-04 12:23:24 EST 
Thanks Markus for the comment. You are able to open system editors for the latest revision in the local history view. This revision is actually the current file.

The new OpenWithAction works with IFileRevision from team plugins. That's why I can't just move it to UI. However because I don't like duplicated code, I will try to handle it (somehow) during M5 while fixing "Open With" in the Repo view.
Comment 11 Igor Burilo CLA 2009-11-12 08:56:43 EST 
Open (OpenRevisionAction) and Open With (OpenWithMenu) actions are from internal API. Will they be available in public API and when (in order to add them to Subversive)?