Bug 119617 - [Wizards] Missing icon in New Class wizard
Summary: [Wizards] Missing icon in New Class wizard
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Curtis d'Entremont CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 118934
  Show dependency tree
 
Reported: 2005-12-07 07:17 EST by Dani Megert CLA
Modified: 2006-02-16 16:34 EST (History)
2 users (show)

See Also:

Attachments
picture of wizrard (9.48 KB, image/png)
2005-12-07 07:17 EST, Dani Megert CLA 		no flags Details
patch (2.51 KB, patch)
2005-12-08 15:56 EST, Curtis d'Entremont CLA 		no flags Details | Diff
new patch (2.58 KB, patch)
2006-01-09 17:27 EST, Curtis d'Entremont CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2005-12-07 07:17:23 EST 
I20051206-1200

Missing icon in New Class wizard, see attached picture.
Comment 1 Dani Megert CLA 2005-12-07 07:17:43 EST 
Created attachment 31289 [details]
picture of wizrard
Comment 2 Martin Aeschlimann CLA 2005-12-08 06:29:16 EST 
I can't reproduce this in I20051206-1200. The image is provided by the wizard. Are you sure your install is complete?
Comment 3 Dani Megert CLA 2005-12-08 06:45:43 EST 
Adapting summary: the icon is there but not visible. Once I resized the wizard, the icon appears.
Comment 4 Karice McIntyre CLA 2005-12-08 13:15:15 EST 
Tod, could this be due to the changes made to TitleAreaDialog made on 12/06 for bug 118934?
Dani, you are using the UI code from HEAD, not from the 1206 build, correct?
Comment 5 Dani Megert CLA 2005-12-08 13:28:40 EST 
I saw it on the build as well. Note that I'm using the old fashioned Windows look i.e. not XP look.
Comment 6 Tod Creasey CLA 2005-12-08 14:54:16 EST 
It happens with XP with the manifest as well. I am rolling back the changes to TitleAreaDialog for Bug 118934 so that we do not ship M5 with this.
Comment 7 Tod Creasey CLA 2005-12-08 14:55:19 EST 
Code rolled back in HEAD. Reassigning to Curtis.
Comment 8 Curtis d'Entremont CLA 2005-12-08 15:56:17 EST 
Created attachment 31415 [details]
patch

My mistake. I had to wedge in an extra composite in TitleAreaDialog because in the createContents it was setting the parent's layout to a FormLayout which is incompatible with trays. However, there was one instance where it still assumed the old composite hierarchy, where it was doing the layout when showing a message. I added one additional layout operation on the newly added composite and it fixes the problem.

Tod (or anyone), can you submit? Thanks
Comment 9 Curtis d'Entremont CLA 2005-12-20 14:54:21 EST 
Can we submit this one now that M4 is out? Thanks!
Comment 10 Tod Creasey CLA 2006-01-09 16:14:23 EST 
        if (dialogArea != null)
            getShell().layout(true);
    	workArea.getParent().layout(true);

Is how the code looks when formatted. Why are you laying out both and why does the workarea always get laid out always?
Comment 11 Curtis d'Entremont CLA 2006-01-09 17:27:46 EST 
Created attachment 32711 [details]
new patch

Removed the extra layout, I tested on several platforms and did not see any problems - the message comes up fine. The extra layout was there as a precaution. Here's the updated patch.
Comment 12 Tod Creasey CLA 2006-01-16 14:26:02 EST 
Patch released for build >20060116
Comment 13 Curtis d'Entremont CLA 2006-01-16 14:42:29 EST 
Resolving as fixed.
Comment 14 Tod Creasey CLA 2006-02-16 16:34:24 EST 
Verified in 20060214-0100