Bug 117752 - [CCombo] CCombo text drawn too high
Summary: [CCombo] CCombo text drawn too high
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Duong Nguyen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 22782
Blocks:
  Show dependency tree
 
Reported: 2005-11-23 12:21 EST by Christof Marti CLA
Modified: 2019-09-06 16:10 EDT (History)
4 users (show)

See Also:

Attachments
Screenshot (1.20 KB, image/gif)
2005-11-23 12:21 EST, Christof Marti CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christof Marti CLA 2005-11-23 12:21:00 EST 
3.2M3

The text of a CCombo by default is drawn too high under Windows XP. CCombo#internalLayout() sets the upper-left bound to (0,0).
Comment 1 Christof Marti CLA 2005-11-23 12:21:57 EST 
Created attachment 30490 [details]
Screenshot
Comment 2 Andre Weinand CLA 2005-11-23 13:29:04 EST 
Positioning the text to (0,0) results in misaligned text if the height of the drop down arrow is larger than the text's height (which is the case for the attached screenshot). I think both the text and the icon should be centered vertically within the container.
Comment 3 Grant Gayed CLA 2006-09-14 16:50:08 EDT 
fixed > 0914
Comment 4 Grant Gayed CLA 2006-09-19 09:58:04 EDT 
Reopening report and taking out this fix, because vertically centering the Text in the CCombo and setting the CCombo's background to the Text's background (so that it all blends together) can fail when:

- the user changes their theme with CCombos open
- a CCombo is disabled

The first case can be handled by adding an SWT.Settings listener to the display and redrawing whenever the theme changes.  However there's no way to handle the second case with existing swt apis.
Comment 5 Grant Gayed CLA 2006-09-19 10:00:29 EDT 
There is a request for api that would help with the second case.  If that request can be implemented on all platforms then this can be revisited.  Marking this report as dependent on bug 22782.
Comment 6 Steve Northover CLA 2007-04-18 03:36:11 EDT 
Grant, what happened here?  Do we still have the problem?
Comment 7 Grant Gayed CLA 2007-04-18 09:10:37 EDT 
Yes, see comment 5.
Comment 8 Steve Northover CLA 2007-04-18 15:42:39 EDT 
Maybe we should put back the old code?
Comment 9 Eclipse Webmaster CLA 2019-09-06 16:10:16 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.