Bug 113849 - History copied many times on each copy
Summary: History copied many times on each copy
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.2 M3   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-10-26 12:27 EDT by John Arthorne CLA
Modified: 2005-10-26 16:50 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2005-10-26 12:27:59 EDT 
Build: I20051025

CopyVisitor visits each node in a resource tree being copied.  On each resource,
it calls HistoryStore.copyHistory.  The copyHistory method does a deep recursion
and seems to copy the history for that entire subtree.  It looks like the
history for each file is copied once for each parent of that file.

Rafael, just CCing you in case you see something obvious I am missing.  I will
investigate further...
Comment 1 Rafael Chaves CLA 2005-10-26 12:48:28 EDT 
If there is anything to be missed, I am missing it too.
Comment 2 John Arthorne CLA 2005-10-26 13:23:41 EDT 
I figured out that I introduced this bug after 3.1 when I merged my refactoring
of resources on IFileSTore.  IHistoryStore.copyHistory clearly says in the API
that it is a deep operation.  In the move case, we only call this method once,
but in the copy case we call it for every resource... In 3.1 this method was
only called for each *file* that was moved, not for folders.
Comment 3 John Arthorne CLA 2005-10-26 16:50:12 EDT 
Fix released.