Community
Participate
Working Groups
Plugin org.eclipse.wst.internet.proxy contributes a preference page for managing internet proxy (firewall) settings. This is a UI plugin which any would-be core (non-UI) plugin would have to depend on to easily retrieve or update these settings. A new org.eclipse.wst.internet.proxy.ui plugin should be created as keeper of the preference page and associated classes. Any code, utility methods or whole classes - namely all of Base64.java and Encoder.java, and bits of InternetPlugin.java and InternetPreferencePage.java - that are non-UI in nature and assist with the retrieval and storage of the internet proxy preference values should be retained in org.eclipse.wst.internet.proxy. Note that InternetPlugin.java and InternetPreferencePage.java currently use AbstractUIPlugin/IPreferenceStore instead of Plugin/Preferences. The code in org.eclipse.wst.internet.proxy will have to be changed to use Plugin/Preferences to avoid dependencies on the UI.
I don't think any other plugins in WST currently depend on org.eclipse.wst.internet.proxy, so M10 seems a reasonable target to complete this change. Also, do not define a public API, since bug 88017 is open to migrate the internet proxy facility into the Eclipse platform.
Raising severity to major. Core plugin providers cannot currently get at the internet proxy settings in a reliable fashion without depending on the GUI.
Deferring out of WTP 1.0. No other providers of core plugins require access to the internet proxy preferences in WTP 1.0 as far as I know. If this changes, we can reconsider this bug for WTP 1.0. Peter, assigned to you as the keeper of the internet proxy preferences page.
changing target from 1.5 M1 to 1.5 M5 to reflect new numbering system as we join Collisto.
Created attachment 34603 [details] Patch for plugin org.eclipse.wst.internet.proxy
Created attachment 34604 [details] New plugin org.eclipse.wst.internet.proxy.ui This zip file contains the files for a new plugin called "org.eclipse.wst.internet.proxy.ui".
This fix involves removing the UI code from the org.eclipse.wst.internet.proxy plugin and creating a new plugin called org.eclipse.wst.internet.proxy.ui. A new internal api was added to access the proxy JVM system properties. The class name for this api is org.eclipse.wst.internet.internal.proxy.InternetProperties. The instance of this new api class can be accessed by calling: InternetPlugin.getInstance().getInternetProperties(); Testing for these changes involved checking that the internet preference page still comes up, that the proxy authenticator is still working, and that setting a proxy host and port in the internet preference page still routes internet traffic to a fire wall. The internet preference page was updated to use this new api which has resulted in this api being tested.
Kathy, this defect is ready to be committed.
This is not going into WTP 1.5. Will reconsider for WTP 2.0 and/or Eclipse platform.
Fixed via bug 154100.
Duplicate.
Closing as verified.
