Description Giovanni Quarella 2005-10-23 10:58:50 EDT

The following code with Eclipse 3.1 works, but with Eclipse 3.2 I have 
problems when I change input.
Exactly when you call for at least the second time

viewer.setInput(movementTableItemProvider);
viewer.setItemCount(movementTableItemProvider.getItemCount());

after setInput this happens:
-----------------------------------------------------------------------
TableView$ViewContentProvider.updateElement(int) line: 109
	TableViewer.virtualSetSelectionToWidget(List, boolean) line: 1151
	TableViewer.setSelectionToWidget(List, boolean) line: 1090
	TableViewer(StructuredViewer).setSelectionToWidget(ISelection, 
boolean) line: 1494
	TableViewer(StructuredViewer).preservingSelection(Runnable) line: 1208
	TableViewer(StructuredViewer).refresh(Object) line: 1262
	TableViewer(StructuredViewer).refresh() line: 1221
	TableViewer.inputChanged(Object, Object) line: 745
	TableViewer(ContentViewer).setInput(Object) line: 248
	TableViewer(StructuredViewer).setInput(Object) line: 1417
	TableView.changeInput(ISelection) line: 277
------------------------------------------------------------------------
When the new input has fewer items than the old one, the method updateElement 
is called for all items of the table not only the visible ones. These items 
doesn't exist at all with new input (the setItemCount is called after setInput)
(I don't have any Selection on the table and I'm not interested to preserve it 
when I change input.)
If I call setItemCount before setInput, in my case I don't have problems with 
non existent items, but the table is still not virtual because the 
updateElement method is called for every index.
With

viewer.setItemCount(0);
viewer.setInput(movementTableItemProvider);
viewer.setItemCount(movementTableItemProvider.getItemCount());

it seems I turn around the bug.


*********************************************************************
*********************************************************************
public class TableView extends ViewPart implements ISelectionListener,
		IPartListener2 {
	public static final String ID 
= "net.mydomain.myrcpapp.views.TableView";

	private TableViewer viewer;

	private ITableItemProviderFactory tableItemProviderFactory;

	private Action action1;

	private Action action2;

	private Action doubleClickAction;

	class ViewContentProvider implements ILazyContentProvider {
		public void inputChanged(Viewer v, Object oldInput, Object 
newInput) {
			if (newInput instanceof TableItemProvider) {

				viewer.getTable().setTopIndex(0);

				if (oldInput instanceof TableItemProvider) {
					if (!((TableItemProvider) 
oldInput).getColumnHeaders()
							.equals(
								
	((TableItemProvider) newInput).getColumnHeaders())) {
						setColumns((TableItemProvider) 
newInput);
					}
				} else if (oldInput == null) {
					setColumns((TableItemProvider) 
newInput);
				}

			}
		}

		public void dispose() {
		}

		public void updateElement(int index) {
			if (viewer.getInput() instanceof TableItemProvider) {
				viewer.replace(
						((TableItemProvider) 
viewer.getInput()).getTableItem(index),
						index);
				// System.out.println("TableItem: " + index);
				// System.out.println("ItemCount: " +
				// viewer.getTable().getItems().length);
			}
		}
	}

	class ViewLabelProvider extends LabelProvider implements
			ITableLabelProvider {
		public String getColumnText(Object obj, int index) {
			return ((ITableItem) obj).getField(index);
		}

		public Image getColumnImage(Object obj, int index) {
			return getImage(obj);
		}

		public Image getImage(Object obj) {
			return PlatformUI.getWorkbench().getSharedImages
().getImage(
					ISharedImages.IMG_OBJ_ELEMENT);
		}
	}

	/*
	 * class NameSorter extends ViewerSorter { }
	 */

	/**
	 * The constructor.
	 */
	public TableView() {
	}

	public void createPartControl(Composite parent) {
		viewer = new TableViewer(parent, SWT.MULTI | SWT.H_SCROLL
				| SWT.V_SCROLL | SWT.VIRTUAL);

		viewer.setContentProvider(new ViewContentProvider());
		viewer.setLabelProvider(new ViewLabelProvider());
		// viewer.setSorter(new NameSorter());

		viewer.setUseHashlookup(true);

		// getViewSite().getPage().addSelectionListener(this);
		// TODO controllare

		getViewSite().getPage().addPartListener(this);

		makeActions();
		hookContextMenu();
		hookDoubleClickAction();
		contributeToActionBars();
	}

	private void hookContextMenu() {
		MenuManager menuMgr = new MenuManager("#PopupMenu");
		menuMgr.setRemoveAllWhenShown(true);
		menuMgr.addMenuListener(new IMenuListener() {
			public void menuAboutToShow(IMenuManager manager) {
				TableView.this.fillContextMenu(manager);
			}
		});
		Menu menu = menuMgr.createContextMenu(viewer.getControl());
		viewer.getControl().setMenu(menu);
		getSite().registerContextMenu(menuMgr, viewer);
	}

	private void contributeToActionBars() {
		IActionBars bars = getViewSite().getActionBars();
		fillLocalPullDown(bars.getMenuManager());
		fillLocalToolBar(bars.getToolBarManager());
	}

	private void fillLocalPullDown(IMenuManager manager) {
		manager.add(action1);
		manager.add(new Separator());
		manager.add(action2);
	}

	private void fillContextMenu(IMenuManager manager) {
		manager.add(action1);
		manager.add(action2);
		// Other plug-ins can contribute there actions here
		manager.add(new Separator
(IWorkbenchActionConstants.MB_ADDITIONS));
	}

	private void fillLocalToolBar(IToolBarManager manager) {
		manager.add(action1);
		manager.add(action2);
	}

	private void makeActions() {
		action1 = new Action() {
			public void run() {
				showMessage("Action 1 executed");
			}
		};
		action1.setText("Action 1");
		action1.setToolTipText("Action 1 tooltip");
		action1.setImageDescriptor(PlatformUI.getWorkbench()
				.getSharedImages()
				.getImageDescriptor
(ISharedImages.IMG_OBJS_INFO_TSK));

		action2 = new Action() {
			public void run() {
				showMessage("Action 2 executed");
			}
		};
		action2.setText("Action 2");
		action2.setToolTipText("Action 2 tooltip");
		action2.setImageDescriptor(PlatformUI.getWorkbench()
				.getSharedImages()
				.getImageDescriptor
(ISharedImages.IMG_OBJS_INFO_TSK));
		doubleClickAction = new Action() {
			public void run() {
				ISelection selection = viewer.getSelection();
				Object obj = ((IStructuredSelection) 
selection).getFirstElement();
				showMessage("Double-click detected on " + 
obj.toString());
			}
		};
	}

	private void hookDoubleClickAction() {
		viewer.addDoubleClickListener(new IDoubleClickListener() {
			public void doubleClick(DoubleClickEvent event) {
				doubleClickAction.run();
			}
		});
	}

	private void showMessage(String message) {
		MessageDialog.openInformation(viewer.getControl().getShell(),
				"TableView", message);
	}

	/**
	 * Passing the focus request to the viewer's control.
	 */
	public void setFocus() {
		viewer.getControl().setFocus();
	}

	private void changeInput(ISelection navigationViewSelection) {
		if (navigationViewSelection instanceof IStructuredSelection) {

			Object obj = ((IStructuredSelection) 
navigationViewSelection).getFirstElement();

			if (obj instanceof ITableItemProviderFactory) {

				if (!obj.equals(tableItemProviderFactory)) {

									
	
					tableItemProviderFactory = 
(ITableItemProviderFactory) obj;

					TableItemProvider 
movementTableItemProvider = tableItemProviderFactory.getTableItemProvider();

					viewer.setInput
(movementTableItemProvider);
					viewer.setItemCount
(movementTableItemProvider.getItemCount());
				}

			}
		}
	}

	private void setColumns(TableItemProvider tableItemProvider) {
		Table virtualTable = viewer.getTable();

		virtualTable.setRedraw(false);
		// virtualTable.setTopIndex(0);

		while (virtualTable.getColumnCount() > 0) {

			int lastOne = virtualTable.getColumnCount() - 1;

			virtualTable.getColumn(lastOne).dispose();
		}

		String[] columnHeaders = tableItemProvider.getColumnHeaders();

		for (int i = 0; i < columnHeaders.length; i++) {
			TableColumn column = new TableColumn(virtualTable, 
SWT.RIGHT);
			column.setText(columnHeaders[i]);
			column.setWidth(120);
			column.setMoveable(true);
		}

		virtualTable.setRedraw(true);
		virtualTable.setHeaderVisible(true);
	}

	// TODO viene chiamata anche per la stessa selezione!
	public void selectionChanged(IWorkbenchPart part, ISelection 
selection) {
		changeInput(selection);
	}

	public void partActivated(IWorkbenchPartReference partRef) {
		// TODO Auto-generated method stub

	}

	public void partBroughtToTop(IWorkbenchPartReference partRef) {
		// TODO Auto-generated method stub

	}

	public void partClosed(IWorkbenchPartReference partRef) {
		// TODO Auto-generated method stub

	}

	public void partDeactivated(IWorkbenchPartReference partRef) {
		// TODO Auto-generated method stub

	}

	public void partOpened(IWorkbenchPartReference partRef) {
		// TODO Auto-generated method stub

	}

	public void partHidden(IWorkbenchPartReference partRef) {
		if (partRef.getId().equals(ID)) {
			getViewSite().getPage().removeSelectionListener(this);
		}
	}

	public void partVisible(IWorkbenchPartReference partRef) {
		if (partRef.getId().equals(ID)) {
			getViewSite().getPage().addSelectionListener(this);
			changeInput(getViewSite().getPage().getSelection
(NavigationView.ID));
		}

	}

	public void partInputChanged(IWorkbenchPartReference partRef) {
		// TODO Auto-generated method stub

	}

}