112742 – [Wizards] Add spell check to commit dialog

Bug 112742 - [Wizards] Add spell check to commit dialog

Summary: [Wizards] Add spell check to commit dialog

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	CVS (show other bugs)
Version:	3.2
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	3.3 M2
Assignee:	platform-cvs-inbox
QA Contact:

URL:
Whiteboard:
Keywords:	contributed

Depends on:
Blocks:

Reported:	2005-10-15 19:03 EDT by Brock Janiczak
Modified:	2006-09-19 14:26 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
higlighting spelling errors (9.25 KB, text/plain) 2006-08-28 02:01 EDT, Eugene Kuleshov	no flags	Details
mylar/context/zip (29.03 KB, application/octet-stream) 2006-08-28 02:01 EDT, Eugene Kuleshov	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Brock Janiczak

2005-10-15 19:03:58 EDT

Version: 3.1.0
Build id: I20051012-1200

As there is no easy way to change a commit comment after the fact, it would be a
really handy feature to be able to check the spelling of your commit comment. 
This could either be a button or check as you type.  As you type would be the
preferred solution as it gives immediate feedback to the user.  There should
also be an option to turn off the checking.

Comment 1 Michael Valenta

2005-10-16 19:24:34 EDT

I agree that this would be useful. We won't have time to address it in 3.2 but 
patches will be accepted.

Comment 2 Mik Kersten

2006-07-05 22:08:16 EDT

Looks like this could on 51444?  Or is there a bug for spell checking in non-editors Text if embedding Text Editors is not the right approach...

Comment 3 Eugene Kuleshov

2006-08-28 02:01:29 EDT

Created attachment 48866 [details]
higlighting spelling errors

This is cleaned version of spelchecker support implemented for Mylar

Comment 4 Eugene Kuleshov

2006-08-28 02:01:30 EDT

Created attachment 48867 [details]
mylar/context/zip

Comment 5 Michael Valenta

2006-08-28 09:35:25 EDT

Thanks for the patch, we'll have a look at it.

Comment 6 Mik Kersten

2006-08-28 12:36:06 EDT

Eugene: I wonder if it is worth making your patch something like a SpellCheckingTextViewerFactory that could more easily be reused.  We could take this patch on Mylar and use it ourselves, and hope that this class moves into a better home in Platform (e.g. via bug 51444).

Comment 7 Eugene Kuleshov

2006-08-28 12:43:58 EDT

(In reply to comment #6)
> Eugene: I wonder if it is worth making your patch something like a
> SpellCheckingTextViewerFactory that could more easily be reused.  We could take
> this patch on Mylar and use it ourselves, and hope that this class moves into a
> better home in Platform (e.g. via bug 51444).

Not sure about this. My patch is using very primitive reconsiler, your stuff need to detect patterns in the text and in future may need to enable rulers and provide completion proposals...

Comment 8 Mik Kersten

2006-08-28 12:49:25 EDT

Right, but I was think that we can provide that by extending what you extracted?  Especially since others are likely to want similar extensions.  But we're digressing from this bug report, so if you think what I propose is worth doing just make a new Mylar bug report.

Comment 9 Michael Valenta

2006-08-30 12:08:13 EDT

I have applied the patch with a minor change. I am using the JFace error text color for the underline instead of the hardcoded red. hanks again.

Comment 10 Michael Valenta

2006-09-11 12:33:38 EDT

I have added this copyright to the file comment. If this is not adequate, please let me know what the copyright shoyuld be:

Eugene Kuleshov (eu@md.pp.ru) - Bug 112742 [Wizards] Add spell check to commit dialog

Comment 11 Michael Valenta

2006-09-19 14:26:04 EDT

Verified fixed in I20060919-0010