Bug 111428 - [HeapStatus] Heap status is updated too frequently
Summary: [HeapStatus] Heap status is updated too frequently
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.2 M3   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
: 111393 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-10-04 08:34 EDT by Andre Weinand CLA
Modified: 2005-12-22 18:41 EST (History)
4 users (show)

See Also:

Attachments
Modified HeapStatus.java (17.92 KB, text/plain)
2005-10-05 18:27 EDT, Brock Janiczak CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Weinand CLA 2005-10-04 08:34:54 EDT 
3.2M2
- launch Eclipse
- on MacOS X start "Quartz Debug" and turn on Flash Screen updates

Observe: the full HeapMonitor control in the status line is redrawn at least once a second
and even if the value hasn't changed. At least redrawing the trash can could be avoided...
Comment 1 Andre Weinand CLA 2005-10-04 08:44:28 EDT 
Redrawing it once per second affects performance on my PowerBook in the range of a few percent.
I think we should only enable the HeapMonitor if its performance impact is neglectable (on all platforms).
Comment 2 Brock Janiczak CLA 2005-10-05 03:06:53 EDT 
I have some code to make the monitor not refresh during idle.  It will only
refresh if the previously displayed value is different to the value to be
displayed by more than 1 meg.  This value could be increased if needed.

Changing the update interval to 1-2 seconds would have a way bigger impact though.

For various reasons, i am unable to create a patch.  Is it ok it i attach the
modified java file (from 3.2 M2)?
Comment 3 Nick Edgar CLA 2005-10-05 10:50:39 EDT 
Brock, attaching the full file would be fine, and thanks for your help.
Comment 4 Brock Janiczak CLA 2005-10-05 18:27:22 EDT 
Created attachment 27918 [details]
Modified HeapStatus.java

Also contains a fix for bug 111409 which you may want to remove.
Comment 5 Michael Van Meekeren CLA 2005-10-11 15:02:30 EDT 
tc - could you review/apply the patch?
Comment 6 Tod Creasey CLA 2005-10-11 16:38:07 EDT 
The patch removed the fix for Bug 110728 which I restored but it was otherwise fine.

Released in build >20051011
Comment 7 Matthew Conway CLA 2005-10-18 20:06:06 EDT 
*** Bug 111393 has been marked as a duplicate of this bug. ***
Comment 8 Tod Creasey CLA 2005-11-01 11:35:32 EST 
Verified in 20051101
Comment 9 Sean Montgomery CLA 2005-12-22 17:56:41 EST 
Sorry to be the bearer of bad tidings, but on the same hardware for which I reported bug 110728, I now find:

Eclipse 3.2M4 on Mac OS X 10.4.3 is using 0.10% of the CPU when at idle with the heap status trim off, but uses 15-30% at idle with it on.

Should I open another bug?  I can provide Activity Monitor samples if you wish.
Comment 10 Andre Weinand CLA 2005-12-22 18:41:07 EST 
Please reopen this bug.