Bug 111165 - [discussion] can files be landmarks?
Summary: [discussion] can files be landmarks?
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows XP
: P1 normal with 1 vote (vote)
Target Milestone: 0.5   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 118007 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-09-29 19:47 EDT by Wesley Coelho CLA
Modified: 2006-03-16 00:11 EST (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wesley Coelho CLA 2005-09-29 19:47:56 EDT
When I right-click on a .java file I have the option of setting it as a 
landmark. It seems that this doesn't have any effect. What I would like to 
happen is for the class(es) in the file become a landmark and the file to 
become bold in the package explorer. This is of particular interest when using 
the Mylar java declaration filter so that landmarked .java files can become an 
indication of interesting corresponding classes. If this isn't the right thing 
to do then at least the option to make a file a landmark should be removed (or 
it should state that the operation failed).


Might be related to bug #110472 (CVS ">" text decorator interfering with 
landmark bolding)
Comment 1 Mik Kersten CLA 2005-10-07 20:19:06 EDT
I've made the UI complain about setting things that can not be landmarks to be
landamrks (e.g. files).  I haven't gone as far as disabling this action because
it is feasible that files can become landmarks at some point, so I'm marking
this report accordingly.

The main issue is the dual purpose that landmarks serve:
1) The are the elements that populate active views
2) They are elements that pop out as being very interesting and are included in
the  first degree of separation search
Comment 2 Benjamin Pasero CLA 2006-01-21 05:59:24 EST
I would like to mark Classes and Packages as landmarks, because I would like to being able to group packages from multiple projects around one task.

My plan was to improve the package-explorers filtering using Mylar. That way I could have a list of tasks that show packages from various projects that are important for that task.

Ben
Comment 3 Mik Kersten CLA 2006-01-26 18:42:58 EST
The current idea is that the packages become implicitly interesting by your working with their contents (e.g. methods, classes).  The packages actually do end up with landmark-level interest, but it doesn't show that way because too much bold ends up appearing on the screen.  But I'm not sure I understand your use case, are you talking about having mutliple tasks active, and only showing interesting packages?   The Visualiser integration (http://www.eclipse.org/ajdt/visualiser/) that we have yet to release will support that since it has a package mode...
Comment 4 Benjamin Pasero CLA 2006-01-27 03:04:20 EST
Thanks I will have a look at the Visualizer.

My usecase was to create Tasks with Mylar that are not fine-granular. So I am interested in creating tasks for various scenarios in my application. The application itself is split up to more than 5 Plugins, for example a Model-Plugin, a DB-Plugin and a View-Plugin.

I could think of creating one task that deals with persistance of the Model. I would then mark the various packages in the model-plugin and db-plugin as landmark.

This is a bit different to just working with methods/classes and let Mylar automatically decide which classes are landmarks. My approach would be that I already know which classes make landmarks, and want to mark them interesting before working with them.

As I mentioned this is a bit like Working Sets and Filters in the Package Explorer, but with far more functionality. E.g. I can quickly switch tasks from the Mylar Tasks view. 

Ben
Comment 5 Peik Aschan CLA 2006-02-23 04:15:55 EST
I have another use case to add (actually I'm surprised nobody has entered it yet). While building web applications, I use Eclipse to edit a lot of files other than Java sources: JSPs, XMLs, Javascript an the like. These files never become landmarks, and Mylar seems to drop them from the interest view every once in a while, so I have to look them up manually. Letting important files other than Java become landmarks would certainly help.
Comment 6 Mik Kersten CLA 2006-02-24 19:07:12 EST
That same use case is annoying me too.  First, Mylar seems to lose interest too quickly when it doesn't know about the structure of a file (only understands Java, build.xml, and plugin.xml right now).  Also those files can become landmarks, and it is sometimes useful to tag them this way manually, so we'll figure out a way to support this better for 0.5.
Comment 7 Wang Bin CLA 2006-03-06 04:36:44 EST
I also suggest to support landmark all type files
Comment 8 Mik Kersten CLA 2006-03-13 17:54:26 EST
*** Bug 118007 has been marked as a duplicate of this bug. ***
Comment 9 David Barri CLA 2006-03-15 21:14:56 EST
I also agree that files should be able to be made landmarks. I am currently working on ruby projects and not being able to make certain ruby files landmarks is a bit of a disadvantage. ;P
Comment 10 Mik Kersten CLA 2006-03-16 00:11:48 EST
Done for 0.4.10, scheduled for tomorrow.  Generic files can now become landmarks implicitly, and can be explicitly set to be landmarks.  Files for which structured elements within them can become landmarks (currently only .java) can not be made landmarks because the elements within them can (otherwise there would be too much bold in the Package Explorer).