Bug 110622 - [Preferences] Cancelling change of repository path leaves new unused connection
Summary: [Preferences] Cancelling change of repository path leaves new unused connection
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows XP
: P5 minor (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2005-09-26 11:48 EDT by Markus Keller CLA
Modified: 2021-09-01 17:40 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2005-09-26 11:48:25 EDT
M20050923-1430

- have a CVS connection like :extssh:mkeller@dev.eclipse.org:/home/eclipse with
some projects in the workspace from that location
- context menu > Properties > CVS
- change path to "/cvsroot/eclipse"
- click OK
- click OK again
- in the "Confirm Project Sharing Changes" dialog, click Cancel
=> action is cancelled, but a new connection
:extssh:mkeller@dev.eclipse.org:/cvsroot/eclipse has been added
=> Since I cancelled, I would expect to have the same connections as before.

After this, the OK button in the Properties dialog is disabled (bug 110617).
Comment 1 Krzysztof Michalski CLA 2007-08-31 05:13:55 EDT
For me it works properly. You confirmed changes on "Confirm Host or Path Change" dialog all repository changes. Click Cancel button on "Confirm Project Sharing Changes" dialog should cancel only sharing not all changes.
Comment 2 Markus Keller CLA 2007-08-31 05:46:59 EDT
(In reply to comment #1)
That's also a valid point of view, although I would then expect that the Properties dialog is closed after I pressed OK there and confirmed the "Host or Path Change" warning.

But I also won't object if you just close this bug.
Comment 3 Dani Megert CLA 2007-08-31 06:08:50 EDT
>For me it works properly. You confirmed changes on "Confirm Host or Path
>Change" dialog all repository changes.
But not for me ;-) The main thing that I confirmed is that I want to rename the repository path of the selected connection and I did note choose to create a new location. Also, I was not informed that this will happen when pressing 'Cancel'.

>But I also won't object if you just close this bug.
The last dialog could at least tell that 'Cancel' will leave everything as is and add a new connection. But I'd claim that 80% of the users wouldn't want such a new connection.
Comment 4 Tomasz Zarna CLA 2007-08-31 08:35:10 EDT
Krzysztof, I'm afraid I need to agree with both Markus and Daniel. When editing a connection's properties you do not expect a new one to be created. It doesn't matter if you agree or not to change sharing of related project(s). If the action had been named "Duplicate connection" it would have been an expected situation.
Comment 5 Eclipse Webmaster CLA 2019-09-06 15:36:44 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 6 Eclipse Genie CLA 2021-09-01 17:40:25 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.