Bug 110186 - [IDE] Prompt when clearing executable attribute on folders
Summary: [IDE] Prompt when clearing executable attribute on folders
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.2 M4   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-21 11:07 EDT by John Arthorne CLA
Modified: 2005-12-13 11:20 EST (History)
2 users (show)

See Also:

Attachments
Proposed fix (3.32 KB, patch)
2005-12-07 11:20 EST, John Arthorne CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2005-09-21 11:07:01 EDT 
This is split from bug 109979.

On Unix platforms, removing the executable bit from a directory means that the
directory contents can no longer be listed.  In Eclipse, this is manifested by
the children being deleted from the Eclipse workspace (Note: the children are
NOT deleted from the file system).  This can be very alarming for the user
because it appears they have lost work.  The property page that allows the
executable bit to be changed should prompt for confirmation when it is changed
on a directory (org.eclipse.ui.internal.ide.dialogs.ResourceInfoPage). Since the
exact behaviour may vary across platforms, I suggest something like:

"Removing the executable attribute from a folder may cause the contents of that
folder to be unreadable, resulting in the appearance that those contents have
been deleted.  Are you sure you want to do this?"
Comment 1 Michael Van Meekeren CLA 2005-11-18 13:55:04 EST 
John can you take this bug?
Comment 2 John Arthorne CLA 2005-11-18 14:11:53 EST 
Sure; I will need to coordinate with Tod since he is currently working on this
dialog.
Comment 3 John Arthorne CLA 2005-12-07 11:20:52 EST 
Created attachment 31306 [details]
Proposed fix
Comment 4 John Arthorne CLA 2005-12-07 11:36:35 EST 
MVM, I wouldn't mind a UI person's opinion on the fix.  I found the warning dialog when setting the executable bit too "in your face".  It would have needed a "don't ask me again" preference, which also seemed a bit heavyweight.  Instead I adopted the convention used in other preference pages to add "Note" label that displays the warning directly in the page (PreferencePage#createNoteLabel).  Since this will only appear on platforms where the executable bit can be set, and only when showing the info page for a folder, this seems like an appropriate place for the warning.
Comment 5 John Arthorne CLA 2005-12-07 14:03:01 EST 
Fix released.
Comment 6 Michael Van Meekeren CLA 2005-12-07 15:03:09 EST 
I'll try this from HEAD or tomorrows build soon
Comment 7 John Arthorne CLA 2005-12-13 11:20:41 EST 
Verified in I20051213-0010.  Verified that the warning does not appear at all on Windows, and that it appears only for folders on Linux GTK.