Bug 110082 - [compiler] Increase compiler performance for "Remove superfluous NLS strings" warnings
Summary: [compiler] Increase compiler performance for "Remove superfluous NLS strings"...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-09-20 15:09 EDT by Frederic Fusier CLA
Modified: 2005-10-30 06:56 EST (History)
0 users

See Also:

Attachments
Proposed improvement (28.91 KB, patch)
2005-09-21 14:35 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2005-09-20 15:09:53 EDT 
Since v_601 we got around 15% performance regression on test
FullSourceWorkspaceASTTests#testDomAstCreationJLS2

After tracking down what happens, it appears that it was a side effect of fix
for bug 48976. COMPILER_PB_NON_NLS_STRING_LITERAL compiler setting was wrongly
still activated after running FullSourceWorkspaceBuildTests test suite and
increase DOM/AST parse time for Parser.java as there were 334 reported warnings.
Comment 1 Olivier Thomann CLA 2005-09-20 15:13:00 EDT 
I will profile this code.
I need to see where we can speed up the detection.
Comment 2 Olivier Thomann CLA 2005-09-21 14:35:24 EDT 
Created attachment 27348 [details]
Proposed improvement

This should improve slightly the performance.
Comment 3 Frederic Fusier CLA 2005-09-21 14:58:42 EDT 
I'll try to confirm your assumption with our performance tests results as soon
as I can...
Comment 4 Olivier Thomann CLA 2005-09-28 09:44:45 EDT 
Fixed and released in HEAD.
No regression tests.
Comment 5 Frederic Fusier CLA 2005-10-30 06:56:04 EST 
Verified for 3.2 M3 using build I20051025-0800: performance test
FullSourceWorkspaceASTTests#testDomAstCreationJLS2 is now correct