Bug 48976 - Remove superfluous $NON-NLS comments
Summary: Remove superfluous $NON-NLS comments
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.2 M2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 83399 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-12-17 05:35 EST by Ilja Preuss CLA
Modified: 2005-09-20 12:32 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilja Preuss CLA 2003-12-17 05:35:07 EST 
$NON-NLS comments without corresponding String literals in the same line should 
optionally produce a compiler warning with an accompanied quick fix to remove 
it.
Comment 1 Dirk Baeumer CLA 2003-12-17 06:18:40 EST 
Moving to JDT/Core since we first need the compiler warning to do so.
Comment 2 Philipe Mulet CLA 2004-05-10 05:38:35 EDT 
Will reconsider post 3.0
Comment 3 Olivier Thomann CLA 2005-07-13 12:42:27 EDT 
Reopen for 3.2 consideration.
Comment 4 Olivier Thomann CLA 2005-07-13 12:43:26 EDT 
*** Bug 83399 has been marked as a duplicate of this bug. ***
Comment 5 Olivier Thomann CLA 2005-07-28 12:26:22 EDT 
Fixed and released in HEAD.
Regression tests added in
org.eclipse.jdt.core.tests.compiler.regression.ExternalizeStringLiteralsTest.test001/003

All projects have been tagged as v600_before_48976 prior to releasing these changes.
Comment 6 Olivier Thomann CLA 2005-08-02 11:19:50 EDT 
Reopen. Will be released post 3.2M1.
Comment 7 Olivier Thomann CLA 2005-08-12 11:03:08 EDT 
Fixed and released in HEAD.
Regression test added in
org.eclipse.jdt.core.tests.compiler.regression.ExternalizeStringLiteralsTest.test001/004
Comment 8 David Audel CLA 2005-09-20 12:32:15 EDT 
Verified in I20050920-0010 for 3.2M2